Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: String definitions for SIL Kit error return codes #163

Merged
merged 2 commits into from
Dec 20, 2024
Merged

dev: String definitions for SIL Kit error return codes #163

merged 2 commits into from
Dec 20, 2024

Conversation

KonradBkd
Copy link
Contributor

@KonradBkd KonradBkd commented Dec 20, 2024 •
edited
Loading

  • Completed C strings in SilKit\source\capi\CapiUtils.cpp
  • More clear exception message formatting
  • Replaced SILKIT with SIL Kit

VDanielEdwards
VDanielEdwards approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good finding with the error code strings!

@KonradBkd KonradBkd merged commit 0bd2e05 into main Dec 20, 2024
13 checks passed
@KonradBkd KonradBkd deleted the dev_exceptions branch December 20, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VDanielEdwards VDanielEdwards VDanielEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KonradBkd @VDanielEdwards