Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: don`t use linker map on Android #144

Merged
merged 2 commits into from
Nov 12, 2024
Merged

cmake: don`t use linker map on Android #144

merged 2 commits into from
Nov 12, 2024

Conversation

MariusBgm
Copy link
Collaborator

@MariusBgm MariusBgm commented Nov 8, 2024 •
edited
Loading

The linker map is not working as intended on an Android NDK build.

Repro

  1. fetch android-ndk
  2. export ANDROID_NDK_HOME=android-ndk-r27c
  3. cd sil-kit && cmake -DCMAKE_TOOLCHAIN_FILE=$ANDROID_NDK_HOME/build/cmake/android.toolchain.cmake -DANDROID_PLATFORM=android-34 -DANDROID_ABI=arm64-v8a -DANDROID_NDK=$ANDROID_NDK_HOME -DSILKIT_BUILD_DEMOS=OFF -DSILKIT_BUILD_STATIC=OFF -DSILKIT_BUILD_TESTS=OFF -B _build/android -S .

The shared library should build cleanly (note, there are some warnings with LLVM18).
As reported in #142

@MariusBgm MariusBgm marked this pull request as ready for review November 8, 2024 14:18
@MariusBgm MariusBgm merged commit 2cd6ffe into main Nov 12, 2024
13 checks passed
@MariusBgm MariusBgm deleted the dev_fix_linking_android branch November 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VDanielEdwards VDanielEdwards VDanielEdwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusBgm @VDanielEdwards