Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demos: lin: fix 'async' mode of the dynamic demo #141

Merged
merged 2 commits into from
Dec 6, 2024
Merged

demos: lin: fix 'async' mode of the dynamic demo #141

merged 2 commits into from
Dec 6, 2024

Conversation

VDanielEdwards
Copy link
Member

Subject

Description

Instructions for review / testing

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards self-assigned this Oct 30, 2024
@VDanielEdwards VDanielEdwards marked this pull request as ready for review November 5, 2024 14:22
KonradBkd
KonradBkd approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@KonradBkd KonradBkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was left for so long, LGTM

@VDanielEdwards VDanielEdwards merged commit 3a517c3 into main Dec 6, 2024
13 checks passed
@VDanielEdwards VDanielEdwards deleted the dev_fix_lin_demo_dynamic branch December 6, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradBkd KonradBkd KonradBkd approved these changes

Assignees

@VDanielEdwards VDanielEdwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VDanielEdwards @KonradBkd