Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: don`t split debug symbols off of static libs #140

Merged
merged 2 commits into from
Nov 4, 2024
Merged

cmake: don`t split debug symbols off of static libs #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
635d54c
cmake: don`t split debug symbols off of static libs
MariusBgm Oct 29, 2024
65efe03
fixup! cmake: don`t split debug symbols off of static libs
MariusBgm Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ option(SILKIT_ENABLE_UBSAN "Enable -f sanitize=undefined for builds (requires gc
option(SILKIT_ENABLE_THREADSAN "Enable -f sanitize=thread for builds (requires gcc, clang)" OFF)
option(SILKIT_ENABLE_COVERAGE "Enable coverage for builds (requires gcc, clang)" OFF)
option(SILKIT_WARNINGS_AS_ERRORS "Treat compiler warnings as errors" OFF)
option(SILKIT_PACKAGE_SYMBOLS "Add a post-build step to create PDB/Symbol archives" ON)
option(SILKIT_PACKAGE_SYMBOLS "Add a post-build step to create PDB/Symbol archives" OFF)
option(SILKIT_BUILD_DASHBOARD "Build the SIL Kit Dashboard client." ON)
option(SILKIT_ENABLE_TRACING_INSTRUMENTATION "Enable tracing instrumentation (_SILKIT_TRACE_CLASS_NAMES)." OFF)
option(SILKIT_LINK_LLD "Use the lld linker for SIL KIT" OFF)
Expand Down
6 changes: 5 additions & 1 deletion SilKit/cmake/SilKitBuildTools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ macro(silkit_split_debugsymbols targetName)
)
endmacro()


macro(silkit_package_debugsymbols targetName)
if(MSVC)
message(STATUS "Creating symbol package ${SILKIT_SYMBOLS_DIR_NAME}")
Expand All @@ -33,6 +32,11 @@ macro(silkit_package_debugsymbols targetName)
return()
endif()
if(UNIX AND CMAKE_BUILD_TYPE MATCHES "Debug")
get_target_property(targetType ${targetName} TYPE)
if(targetType STREQUAL STATIC_LIBRARY)
message(STATUS "SIL Kit: splitting debug symbols on static libraries is not supported")
return()
endif()

silkit_split_debugsymbols("${targetName}")

Expand Down
Loading