Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintenance: remove unused capture, member, and argument #138

Merged
merged 2 commits into from
Oct 28, 2024
Merged

maintenance: remove unused capture, member, and argument #138

merged 2 commits into from
Oct 28, 2024

Conversation

VDanielEdwards
Copy link
Member

Subject

Remove a few unused variables that caused warnings with some compilers.

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards self-assigned this Oct 25, 2024
VJonasHolley
VJonasHolley approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@VJonasHolley VJonasHolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one minor formatting issue in the ITest_MessageAggregation, besides LGTM!

SilKit/IntegrationTests/ITest_MessageAggregation.cpp Outdated Show resolved Hide resolved
@VDanielEdwards VDanielEdwards merged commit f3d05c2 into main Oct 28, 2024
13 checks passed
@VDanielEdwards VDanielEdwards deleted the dev_remove_unused_members branch October 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VJonasHolley VJonasHolley VJonasHolley approved these changes

Assignees

@VDanielEdwards VDanielEdwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VDanielEdwards @VJonasHolley