cmake: improve platform/compiler/architecture detection and make cross-building to QNX on Windows possible #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-building to QNX on Windows possible
…ke cross-building to QNX on Windows possible
VDanielEdwards
changed the title
…ke cross-building to QNX on Windows possible
MariusBgm
approved these changes
Oct 24, 2024
…ke cross-building to QNX on Windows possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR adapts the platform/compiler/architecture extraction logic to allow cross-builds to QNX on Windows. It also unifies some logic and adds VS2022 detection, with a new fallback for 'unknown' MSVC toolset versions.
It also adapts the QNX toolchain base file to skip settings the rpath on the build-artifacts which is extremely broken on Windows. Since the QNX binaries (e.g., test executables) cannot be executed on the host (not the cross-build target) anyway, this shouldn't break anything.
Description
Instructions for review / testing
Developer checklist (address before review)