Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SILKIT-1612 log: add participant name to file names #132

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

MariusBgm
Copy link
Collaborator

Ensure that filenames are (more) unique, just in case multiple log files are opened in quick succession.
In the future we might want to provide some templating for the user to choose the file name.

@MariusBgm MariusBgm marked this pull request as ready for review October 11, 2024 08:07
Copy link
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

𝔏𝔊𝔗𝔐 👍

@MariusBgm
Copy link
Collaborator Author

I'll update the documentation string for Logname

@MariusBgm MariusBgm merged commit 4c02d27 into main Oct 11, 2024
13 checks passed
@MariusBgm MariusBgm deleted the dev_logging_participant_name branch October 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants