fix(stdlib): human time parse duration error for decimals

[sainad2222]

Credits to @titaneric for original implementation

Summary

New humantime parse duration function doesn't support decimals. So falling back to old method(regex) when ht_parse_duration fails

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

Is this a breaking change?

• Yes
• No

How did you test this PR?

cargo test parse_duration
./scripts/checks.sh

Does this PR include user facing changes?

• Yes. Please add a changelog fragment based on
  our guidelines.
• No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

• Our CONTRIBUTING.md is a good starting place.
• If this PR introduces changes to LICENSE-3rdparty.csv, please
  run dd-rust-license-tool write and commit the changes. More details here.
• For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

• Closes: Vector 0.44.0 no longer support decimal in parse_duration vector#22255

[titaneric]

Thank you for trying for fixing this! Is it possible to support multi-units duration in the implementation as well?
In fact, I have the previous implementation here.

[pront]

Thank you for trying for fixing this! Is it possible to support multi-units duration in the implementation as well? In fact, I have the previous implementation here.

Good idea, it could have been in a separate function but I am fine to include in this one as long as we include some more tests 👍

[sainad2222]

Test cases for multi units duration are already present ig. Any sample test case? Just wanted to understand what kind of new test cases needs to be added just so that we are on the same page

[titaneric]

Perhaps testcase for multi-unit and fractional time duration?

[sainad2222]

Ahh got it

[sainad2222]

Added. Thanks @titaneric for the logic

[jszwedko]

@titaneric if we are adding support to the existing implementation to handle multiple units, is there any reason to keep the implementation using humantime around? Does it offer any other advantages that would motivate supporting both implementations?

[titaneric]

I am not sure, to be honest.
I think if we need to handle fractional and multi-units duration parsing, we need to handle by ourselves.

I think we could remove the humantime crate this time.

[sainad2222]

Not sure if we want to support weeks. Either we remove support for both w_ns and s_w or keep it as it is. Let me your thoughts

[titaneric]

I think week is a common unit, and I think we could support it

[pront]

Thanks for supporting a week here. Maybe we can have another test as well e.g. "8d"?

[sainad2222]

Added

[jszwedko]

I think if we need to handle fractional and multi-units duration parsing, we need to handle by ourselves.

I agree, it seems like we need to handle the parsing ourselves.

[titaneric]

I think it's ok, and I would leave this PR to maintainer to approve it.

[pront]

Awesome, thank you @sainad2222 and @titaneric.