Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(parse_groks): expose internal errors #1113

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

neuronull
Copy link
Contributor

@neuronull neuronull commented Nov 7, 2024

Summary

parse_grok follows the Datadog Log's Grok algorithm's behavior where errors in applying filters are non fatal.
This change surfaces those filter errors to the caller, and differentiates between fatal and non fatal, as outlined by the Datadog Log's Grok algorithm, allowing the caller to decide whether to align with that or differ.

The stdlib parse_groks was unmodified, as such this is not a change to user facing behavior. If we decide to change that, we can do it in a follow up change.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Added/corrected unit tests

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

@neuronull neuronull force-pushed the neuronull/OPA-2627_parse_grok_surface_filter_errors branch from 811d3bd to 3c84964 Compare November 7, 2024 16:54
@neuronull neuronull marked this pull request as ready for review November 7, 2024 16:58
changelog.d/1113.breaking.md Outdated Show resolved Hide resolved
@neuronull neuronull changed the title fix(parse_groks): surface grok filter errors fix(parse_groks)!: surface grok filter errors Nov 7, 2024
@neuronull neuronull added the type: bug A code related bug label Nov 7, 2024
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree that we should introduce this breaking change to fix the data loss scenario.

src/datadog/grok/parse_grok.rs Show resolved Hide resolved
src/datadog/grok/parse_grok.rs Outdated Show resolved Hide resolved
@neuronull neuronull added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 8, 2024
@neuronull neuronull changed the title fix(parse_groks)!: surface grok filter errors chore(parse_groks): expose non recoverable errors Nov 8, 2024
Copy link
Contributor

@tessneau tessneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks for the changes 🙏 should we remove the bug label with the latest update?

@neuronull neuronull removed the type: bug A code related bug label Nov 8, 2024
src/datadog/grok/parse_grok.rs Outdated Show resolved Hide resolved
src/datadog/grok/parse_grok.rs Show resolved Hide resolved
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still confused by the error type naming, but I will approve this to unblock further work.

src/datadog/grok/parse_grok.rs Outdated Show resolved Hide resolved
@neuronull neuronull changed the title chore(parse_groks): expose non recoverable errors chore(parse_groks): expose internal errors Nov 12, 2024
@pront pront added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit d5fb838 Nov 12, 2024
14 checks passed
@pront pront deleted the neuronull/OPA-2627_parse_grok_surface_filter_errors branch November 12, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants