-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump idna from 0.5.0 to 1.0.2 #1002
Conversation
Bumps [idna](https://github.com/servo/rust-url) from 0.5.0 to 1.0.2. - [Release notes](https://github.com/servo/rust-url/releases) - [Commits](servo/rust-url@v0.5.0...idna-v1.0.2) --- updated-dependencies: - dependency-name: idna dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
Possibly blocked by servo/rust-url#961 |
A newer version of idna exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Signed-off-by: Jesse Szwedko <[email protected]>
@esensar I'm curious if you think the lack of specificity in the errors returned by idna 1 will be an usability issue. It now no longer returns specific error types, but rather just that an error occurred. See the comment from the maintainer here: servo/rust-url#961 (comment). |
The functions themselves didn't really do anything with these errors, other than reporting them. I am not sure if anything useful could have been done with these in VRL to be honest. I just exposed them because they were available. If needed for better logs, we could maybe use the config mentioned in servo/rust-url#961 (comment) (but only in cases of errors). Not sure if that would provide value though. |
Signed-off-by: Jesse Szwedko <[email protected]>
Thanks for the thoughts @esensar ! I'll mark this for merge, but we can consider surfacing the domain with replacement characters in the case of errors in the future. |
Bumps idna from 0.5.0 to 1.0.2.
Release notes
Sourced from idna's releases.
Commits
6be49d0
Remove no_std category (crates.io doesn't support it, and it is now rejected)...5019dd5
Merge pull request #949 from hsivonen/overflow4a14519
Adjust Punycode overflow checksdcfbed3
Update idna to 1.0.1 (#945)467ef63
fix panic onxn--55555577
(#940)3d6dbbb
Reimplement idna on top of ICU4X (#923)de947ab
Document possible replacements of the base URL (#926)8b8431b
docs: document SyntaxViolation variants, remove bare URLs (#924)fd042e0
Non-special URLs can have their paths erased (#921)49eea1c
Fix multiple issues on wasm32: (#886)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)