chore: build x86_64-unknown-linux-musl with all features

[binarylogic]

@a-rodin demonstrated a full build on Alpine linux (#661 (comment)) which allows us to release a full build for target x86_64-unknown-linux-musl without limited features. This change updates our release process for that target to follow that example.

Ref #661, #630, #654

[ghost]

Note that the resulting binary is not fully static, as it is linked dynamically to both musl and libstdc++.

It means that it can be used to create an Alpine-based Docker image, but not a stand-alone binary that can be distributed separately.

I think this repo looks like a promising base to build fully static binary, I'm actually going to try it out and report the results later.

[binarylogic]

Ah got it. Yeah, this is definitely not my area of expertise. I'll see if I can adjust this for the Alpine image only.

[ghost]

I'll try to create a PR that would build an Alpine image without dev dependencies using multi-stage builds.

[binarylogic]

Sure, I was just going to update this Dockerfile and do exactly what you said with the multi-stage build.

[binarylogic]

I updated the alpine Docker image to follow your example. You'll notice here we still require g++ and gcc.

[ghost]

Here libgcc and libstd++ can be be used, so the command can be like

RUN apk --no-cache add libgcc libstdc++

to keep to container smaller.

[binarylogic]

Done, thanks!

[LucioFranco]

is this missing an entrypoint?

[binarylogic]

What is proper Docker etiquette here?

[LucioFranco]

if this is a container someone might use to run vector then you want the entry point to be the binary. Check below.

https://github.com/timberio/vector/blob/434bed8bce6d78517d9d8c07240305df0512ec27/Dockerfile#L40

[LucioFranco]

@binarylogic I think if we can add the entrypoint back then its a +1 from me.

[LucioFranco]

why are we copying this folder? I think at a min we should only copy what we need?

[binarylogic]

That folder is designed to hold any binaries we want to ship, which currently is only vector. I thought it was more future proof to do it this way.