Skip to content

chore(deps): Reenable sasl #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 16, 2020
Merged

chore(deps): Reenable sasl #3081

merged 5 commits into from
Jul 16, 2020

Conversation

Hoverbear
Copy link
Contributor

Closes #3080 :)

@Hoverbear
chore(deps): Reenable sasl
0e2843b 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear added sink: kafka Anything `kafka` sink related source: kafka Anything `kafka` source related domain: security Anything related to security labels Jul 16, 2020
@Hoverbear Hoverbear requested a review from fanatid July 16, 2020 00:28
@Hoverbear Hoverbear self-assigned this Jul 16, 2020
@Hoverbear
Copy link
Contributor Author

Let's merge this for #2961

@fanatid
Copy link
Contributor

fanatid commented Jul 16, 2020

Vendored build works on Windows?

rdkafka-sys depends from sasl2-sys
https://github.com/fede1024/rust-rdkafka/blob/0c02524ee95c509b8ec0de6c801016c2457ddf17/rdkafka-sys/Cargo.toml#L57

sasl2-sys depends from krb5-src
https://github.com/MaterializeInc/rust-sasl/blob/f54598c7e4815bc29852be7217f384e9b21b4966/sasl2-sys/Cargo.toml#L21

rkb5-src compile fail on windows
MaterializeInc/rust-krb5-src#10

@Hoverbear
Copy link
Contributor Author

Ah! I think I need to split up the vendor flags a bit better. :) Let's see...

Hoverbear added 2 commits July 16, 2020 08:00
@Hoverbear
Fiddle with features
d57fe5a 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear
Generate
1304508 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear requested a review from binarylogic as a code owner July 16, 2020 15:04
@Hoverbear
Add sasl to ubuntu ci
3cdd5d8 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear removed the request for review from binarylogic July 16, 2020 16:22
@Hoverbear
Copy link
Contributor Author

Need to disable sasl on MSVC for now.

@Hoverbear
Copy link
Contributor Author

This looks good!

@fanatid
Copy link
Contributor

fanatid commented Jul 16, 2020

So idea disable sasl for windows and enable for everything rest? Should default and default-cmake have vendor-sasl as default-musl?

@Hoverbear
Copy link
Contributor Author

I think that's the easiest solution for now, yeah. :(

fanatid
fanatid approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@fanatid fanatid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need green CI.

@Hoverbear
Copy link
Contributor Author

@Hoverbear Hoverbear merged commit 59871fd into master Jul 16, 2020
@MOZGIII
Copy link
Contributor

MOZGIII commented Jul 16, 2020

Do we link sasl staticly now?

@fanatid
Copy link
Contributor

fanatid commented Jul 17, 2020

Yes, rdkafka/gssapi-vendored feature should link the library statically.

@fanatid fanatid deleted the reenable-sasl branch July 17, 2020 06:37
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
@Hoverbear
chore(deps): Reenable sasl (vectordotdev#3081)
50e91b6 
* chore(deps): Reenable sasl

Signed-off-by: Ana Hobden <[email protected]>

* Fiddle with features

Signed-off-by: Ana Hobden <[email protected]>

* Generate

Signed-off-by: Ana Hobden <[email protected]>

* Add sasl to ubuntu ci

Signed-off-by: Ana Hobden <[email protected]>

* Write docs for windows sasl

Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Brian Menges <[email protected]>
@smlgbl
Copy link
Contributor

smlgbl commented Mar 15, 2022

Is this still an open issue somehow? Trying to authenticate with sasl.mechanism = "SCRAM-SHA-256" gives me the following error:

Configuration error. error=Source "kafka-in-aiven": Could not create Kafka consumer: Client creation error: No provider for SASL mechanism SCRAM-SHA-256: recompile librdkafka with libsasl2 or openssl support. Current build options: PLAIN

Running on 0.20.0-alpine

@jszwedko
Copy link
Member

Hi @smlgbl !

sasl is not enabled for the MUSL-based builds (aka alpine linux). It should work on the glibc-based builds though (-debian and -distroless-libc.

I can't remember why we don't enable it on MUSL builds though. I'll try to enable it and see what the build failure is.

jszwedko added a commit that referenced this pull request Mar 15, 2022
@jszwedko
chore: re-enable GSSAPI for Kafka for all targets
3c639db 
Pushing up to see what the build failures are if any, prompted by
#3081 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko mentioned this pull request Mar 15, 2022
Closed
@smlgbl
Copy link
Contributor

smlgbl commented Mar 15, 2022

Hi @smlgbl !

sasl is not enabled for the MUSL-based builds (aka alpine linux). It should work on the glibc-based builds though (-debian and -distroless-libc.

I can't remember why we don't enable it on MUSL builds though. I'll try to enable it and see what the build failure is.

It's true. It's working with the -debian build...

@Hoverbear Hoverbear removed their assignment Mar 15, 2022
@Ilmarii Ilmarii mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanatid fanatid fanatid approved these changes

Assignees
No one assigned
Labels
domain: security Anything related to security sink: kafka Anything `kafka` sink related source: kafka Anything `kafka` source related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Re-enable SASL in Kafka
5 participants
@Hoverbear @fanatid @MOZGIII @smlgbl @jszwedko