chore(kafka sink): disable sasl feature #2930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Fomichev <[email protected]>
fanatid
added
sink: kafka
MOZGIII
approved these changes
Jul 1, 2020
|
How about merging this? It'll unblock the k8s E2E tests at CI. |
|
I thought I approved this! Sorry. |
|
Do you think we could re-enable this anytime soon? I was hoping to announce SASL in 0.10.0 :( (#2961 ) |
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
Signed-off-by: Kirill Fomichev <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of #2915.
saslis problematic right now. Problems with building statically linked, problems with using new not published vendored feature in rdkafka-sys (win32 not supported yet).saslstill will be available, but users will need build binaries themselves.This PR close #2928 and #2929. After landing we need create issue for tracking.