Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): #22264 add --no-environment to systemd service file at ExecReload #22279

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

rsrdesarrollo
Copy link
Contributor

Summary

Add option --no-environment to avoid checking for environment requirements on service reload.
As described in #22264, without this, configurations with sources like splunk_hec will not be able to perform a reload via systemctl.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

#22264 #20589

@rsrdesarrollo rsrdesarrollo requested a review from a team as a code owner January 22, 2025 17:27
@bits-bot
Copy link

bits-bot commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: releasing Anything related to releasing Vector label Jan 22, 2025
@pront pront enabled auto-merge January 22, 2025 17:49
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rsrdesarrollo. Can you add a changelog for this please?

@pront pront changed the title fix: #22264 add --no-environment to systemd service file at ExecReload fix(deployment): #22264 add --no-environment to systemd service file at ExecReload Jan 22, 2025
@pront pront changed the title fix(deployment): #22264 add --no-environment to systemd service file at ExecReload fix(deployment): #22264 add --no-environment to systemd service file at ExecReload Jan 22, 2025
auto-merge was automatically disabled January 23, 2025 11:26

Head branch was pushed to by a user without write access

@rsrdesarrollo
Copy link
Contributor Author

No problem, thanks!

@pront pront enabled auto-merge January 23, 2025 14:30
@pront pront added this pull request to the merge queue Jan 23, 2025
Merged via the queue into vectordotdev:master with commit b890bf6 Jan 23, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: releasing Anything related to releasing Vector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants