chore(dev): fix vdev check scripts warnings
#22277
Merged
+14
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: releasing
pront
added
no-changelog
pront
changed the title
pront
changed the title
pront
changed the title
vdev check scripts warnings
jszwedko
approved these changes
Jan 22, 2025
pront
commented
Jan 22, 2025
| @@ -5549,7 +5549,7 @@ version = "0.1.3" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "c0ff37bd590ca25063e35af745c343cb7a0271906fb7b37e4813e8f79f00268d" | |||
| dependencies = [ | |||
| "bitflags 2.6.0", | |||
| "bitflags 2.8.0", | |||
There was a problem hiding this comment.
:yikes: this snuck in but it's fine to include IMO
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.47s Total Time |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions
bot
added
the
domain: releasing
pront
commented
Jan 22, 2025
| check_curl_for_retry_support | ||
| _retry="$RETVAL" | ||
| if check_curl_for_retry_support; then | ||
| _retry=(--retry 3) |
There was a problem hiding this comment.
treats "retry" and "3" as separate arguments, before it would treat "--retry 3" as a single arg
buraizu
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Side-effect: Cargo.lock bitflags
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References