Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump async-nats to v0.38 #22238

Merged
merged 3 commits into from
Jan 17, 2025
Merged

chore(deps): bump async-nats to v0.38 #22238

merged 3 commits into from
Jan 17, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 17, 2025

Summary

Bump to the latest version.
Ideally we want to enable the fips feature but it's not trivial: #21504

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from a team as a code owner January 17, 2025 19:09
@pront pront requested a review from bfung January 17, 2025 19:09
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 17, 2025
@pront pront enabled auto-merge January 17, 2025 19:09
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 17, 2025

Datadog Report

Branch report: pront/bump-nats-no-fips
Commit report: 98f1d4d
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

Copy link
Contributor

@bfung bfung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved, pending test suite passes.

Taking a look at the release notes, it looks like async-nats has breaking changes between 0.33.0 to 0.38.0, but will rely on test suite to catch those.

@pront pront added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit 78cb547 Jan 17, 2025
74 checks passed
@pront pront deleted the pront/bump-nats-no-fips branch January 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants