chore(dev): fix protoc installation script for macOS arm64 #22221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the protoc version from 3.19.5 to 3.20.2 in `scripts/environment/install-protoc.sh`. The [3.19.5 release](https://github.com/protocolbuffers/protobuf/releases/tag/v3.19.5) of protocol buffers don't include assets for macOS arm64, hence the script fails on the same. The bump is to 3.20.2 instead of 3.20.3 because for some reason, only the [3.20.2 release](https://github.com/protocolbuffers/protobuf/releases/tag/v3.20.2) contains assets for macOS arm64. Furthermore, modify the flags passed to the `mv` command to be macOS compatible. Signed-off-by: Sanskar Jaiswal <[email protected]>
github-actions
bot
added
the
domain: ci
pront
approved these changes
Jan 16, 2025
|
Thank you @aryan9600 👍 |
pront
changed the title
pront
added
the
no-changelog
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think these are very flaky: https://github.com/vectordotdev/vector/actions/runs/12813489793/job/35727692148 |
Merged
via the queue into
vectordotdev:master
with commit Jan 16, 2025
ca73a06
89 of 92 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump the protoc version from 3.19.5 to 3.20.2 in
scripts/environment/install-protoc.sh. The 3.19.5 release of protocol buffers don't include assets for macOS arm64, hence the script fails on the same.The bump is to 3.20.2 instead of 3.20.3 because for some reason, only the 3.20.2 release contains assets for macOS arm64.
Furthermore, modify the flags passed to the
mvcommand to be macOS compatible.Change Type
Is this a breaking change?
How did you test this PR?
By running the script on a macOS arm64 machine.
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References