fix(aws_s3 source): replace info! with debug! to avoid spam

[pront]

Summary

These were missing the internal_log_rate_limit attribute. But also, based on https://github.com/vectordotdev/vector/blob/master/STYLE.md#basic-usage they should have been debug! statements.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

Is this a breaking change?

• Yes
• No

How did you test this PR?

Does this PR include user facing changes?

• Yes. Please add a changelog fragment based on our guidelines.
• No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

• Please read our Vector contributor resources.
  • make check-all is a good command to run locally. This check is
    defined here. Some of these
    checks might not be relevant to your PR. For Rust changes, at the very least you should run:
    • cargo fmt --all
    • cargo clippy --workspace --all-targets -- -D warnings
    • cargo nextest run --workspace (alternatively, you can run cargo test --all)
• If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
  run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

[datadog-vectordotdev]

Datadog Report

Branch report: pront/fix-sqs-spam
Commit report: b722932
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

[jszwedko]

I'd suggest looping in the author that added these to see if it is still useful for them as a throttled log. If it isn't we could consider dropping it altogether and re-adding it once we figure out a better way to do so without increasing noise.

[pront]

Original PR: #22083.

Please take a look at the above cc @fdamstra

[fdamstra]

I do not think this is useful as a throttled log nor as a debug log. IMO, this information is appropriate to be logged in full, and the info level is appropriate.

This is similar to what the file source does when it detects, adds, and finishes processing a new input file.

Similar, for files ingested through s3, we want a record that every file was ingested to ensure completeness.

Is this addressing a complaint? I'm curious of the use case where this information isn't desired. The lack of these logs has been a major source of frustration for my users. Perhaps there's a way to make it a configurable option?

[pront]

Another user complained in Discord today: thread.

Relying on logs/traces doesn't sound robust. How about we introduced another aws_s3 source output and publish audit events to it? Open to more ideas of course.

[fdamstra]

I'm okay with this being merged, but would like to continue discussions. If we drop it to debug I should be able to set VECTOR_LOG=sources::aws_s3=debug,info and get the data we need.

[fdamstra]

I do think internal_log_rate_limit should be set to false. People who want this information want it for every object.

[pront]

Done in 9bb3978.

[jszwedko]

Created a new 0.44.1 milestone and added this here: https://github.com/vectordotdev/vector/milestone/138