Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(releasing): refactor homebrew.rs to support ARM builds #22156

Merged
merged 2 commits into from
Jan 14, 2025
Merged

feat(releasing): refactor homebrew.rs to support ARM builds #22156

merged 2 commits into from
Jan 14, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 10, 2025 •
edited
Loading

Summary

  • Update the homebrew.rs binary to support ARM64 macOS builds.
  • Greatly simplified replacement logic

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

On my fork with:

cargo run --package vdev --bin vdev -- -v release homebrew  --username pront

Result is here:
pront/homebrew-brew@d741381

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Depends on: vectordotdev/homebrew-brew#22

Ref: #10193

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 10, 2025
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Jan 10, 2025
@pront pront changed the title feat(dev): refactor homebrew.rs to support ARM builds feat(releasing): refactor homebrew.rs to support ARM builds Jan 10, 2025
@pront pront added the domain: releasing Anything related to releasing Vector label Jan 10, 2025
@pront pront added this to the Vector v0.44.0 milestone Jan 10, 2025
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/hombebrew-macos-arm
Commit report: bea8d5b
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@pront pront marked this pull request as ready for review January 14, 2025 16:15
@pront pront requested a review from a team as a code owner January 14, 2025 16:15
jszwedko
jszwedko approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pront pront added this pull request to the merge queue Jan 14, 2025
Merged via the queue into master with commit b77e6c1 Jan 14, 2025
61 checks passed
@pront pront deleted the pront/hombebrew-macos-arm branch January 14, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: releasing Anything related to releasing Vector domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
Vector v0.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko