fix(ci): macOS runner for Intel #22134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
added
the
no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.42s Total Time |
pront
commented
Jan 7, 2025
| @@ -268,7 +268,7 @@ jobs: | |||
|
|
|||
| build-x86_64-apple-darwin-packages: | |||
| name: Build Vector for x86_64-apple-darwin (.tar.gz) | |||
| runs-on: macos-latest-xlarge | |||
| runs-on: macos-latest-large | |||
There was a problem hiding this comment.
The macos-verify job runs on [macos-14, macos-15]. I wonder if it should just run on macos-latest-large.
There was a problem hiding this comment.
I think the macos-verify job will fail with this update, no?, due to the CPU architecture not matching.
jszwedko
reviewed
Jan 7, 2025
jszwedko
approved these changes
Jan 7, 2025
10 tasks
titaneric
pushed a commit
to titaneric/vector
that referenced
this pull request
Jan 9, 2025
* fix(ci): macOS runner for Intel * fix macos-verify
titaneric
pushed a commit
to titaneric/vector
that referenced
this pull request
Jan 15, 2025
* fix(ci): macOS runner for Intel * fix macos-verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
macos-latest-xlargeis for ARM architecture based on https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners.This PR is an immediate fix. Will followup with another PR to add support for both ARM and Intel and fix the verification step.
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References
Ref: #22129