Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prometheus_scrape): federate query match url building #22085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sainad2222
Copy link

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

sources:
  prom_source:
    endpoints:
      - "http://localhost:9090/federate"
    honor_labels: true
    scrape_interval_secs: 60
    scrape_timeout_secs: 45
    query:
      match:
        - '{job="node"}'
    tls:
      verify_certificate: false
      verify_hostname: false
    type: prometheus_scrape

sinks:
  output:
    type: "console"
    inputs: ["prom_source"]
    target: "stdout"
    encoding:
      codec: "json"

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@sainad2222 sainad2222 requested a review from a team as a code owner December 27, 2024 18:19
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus_scrape source's query doesn't add the [] to mapping list
1 participant