Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(administration): add SMP as code owners for the "regression/" dir tree #21597

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

pront
Copy link
Member

@pront pront commented Oct 23, 2024

No description provided.

@pront pront requested a review from a team as a code owner October 23, 2024 17:59
@pront pront requested a review from jszwedko October 23, 2024 17:59
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Oct 23, 2024

Datadog Report

Branch report: pront-patch-1
Commit report: 3395a8f
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 23, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious to get @vectordotdev/single-machine-performance's thoughts here. I think they wouldn't really consider themselves the owners of the experiment definitions, just the infrastructure that executes them.

@pront
Copy link
Member Author

pront commented Oct 23, 2024

I'd be curious to get @vectordotdev/single-machine-performance's thoughts here. I think they wouldn't really consider themselves the owners of the experiment definitions, just the infrastructure that executes them.

I thought they might need this for lading/SMP upgrades. But if not required, happy to close the PR.

@jszwedko
Copy link
Member

I'd be curious to get @vectordotdev/single-machine-performance's thoughts here. I think they wouldn't really consider themselves the owners of the experiment definitions, just the infrastructure that executes them.

I thought they might need this for lading/SMP upgrades. But if not required, happy to close the PR.

You could define ownership over just the regression workflow definitions in .github/workflows and then also regression/config.yaml

@GeorgeHahn
Copy link
Contributor

I'd be curious to get @vectordotdev/single-machine-performance's thoughts here. I think they wouldn't really consider themselves the owners of the experiment definitions, just the infrastructure that executes them.

I thought they might need this for lading/SMP upgrades. But if not required, happy to close the PR.

You could define ownership over just the regression workflow definitions in .github/workflows and then also regression/config.yaml

I think this would be preferable

@pront pront added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit f8897c8 Oct 24, 2024
55 checks passed
@pront pront deleted the pront-patch-1 branch October 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants