-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): use correct series payload origin labels #21068
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time |
Regression Detector ResultsRun ID: 8903c222-c9a3-41db-b212-5b4914a7accb Metrics dashboard Baseline: 7f206cd Performance changes are noted in the perf column of each table:
Significant changes in experiment optimization goalsConfidence level: 90.00%
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
❌ | file_to_blackhole | egress throughput | -14.00 | [-20.29, -7.71] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
✅ | syslog_log2metric_humio_metrics | ingress throughput | +5.16 | [+5.03, +5.29] | |
➖ | socket_to_socket_blackhole | ingress throughput | +3.73 | [+3.68, +3.78] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +2.74 | [+2.65, +2.83] | |
➖ | otlp_http_to_blackhole | ingress throughput | +2.64 | [+2.52, +2.77] | |
➖ | http_text_to_http_json | ingress throughput | +1.89 | [+1.77, +2.02] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +1.40 | [+1.29, +1.51] | |
➖ | http_elasticsearch | ingress throughput | +1.04 | [+0.86, +1.21] | |
➖ | splunk_hec_route_s3 | ingress throughput | +0.30 | [-0.02, +0.61] | |
➖ | http_to_http_noack | ingress throughput | +0.11 | [+0.04, +0.17] | |
➖ | http_to_http_json | ingress throughput | +0.02 | [-0.02, +0.05] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.02 | [-0.07, +0.11] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.11, +0.12] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.00 | [-0.10, +0.10] | |
➖ | http_to_s3 | ingress throughput | -0.27 | [-0.54, -0.00] | |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.54 | [-0.62, -0.46] | |
➖ | syslog_loki | ingress throughput | -0.71 | [-0.78, -0.64] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -0.78 | [-0.89, -0.67] | |
➖ | http_to_http_acks | ingress throughput | -0.87 | [-2.19, +0.46] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -1.00 | [-1.20, -0.81] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -1.22 | [-1.42, -1.03] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -1.45 | [-1.58, -1.31] | |
➖ | fluent_elasticsearch | ingress throughput | -1.87 | [-2.35, -1.38] | |
➖ | syslog_humio_logs | ingress throughput | -1.97 | [-2.06, -1.87] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -2.12 | [-2.23, -2.01] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -3.31 | [-3.48, -3.15] | |
❌ | file_to_blackhole | egress throughput | -14.00 | [-20.29, -7.71] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
The labels changed downstream, so we need to use the correct ones. This only applies to the v1 series endpoint.