Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sources): annotation suppression failed when log_namespace is enabled in kubernetes_logs #21045

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iFurySt
Copy link
Contributor

@iFurySt iFurySt commented Aug 11, 2024

Close #20682

Before:
Xnip2024-08-11_23-16-04

After:
Xnip2024-08-11_23-16-23

Config:

schema:
    log_namespace: true

sources:
    source_kubernetes:
      type: kubernetes_logs
      self_node_name: "abc123"
      pod_annotation_fields:
        container_id: ""
        container_image_id: ""
      #   pod_labels: ""
      #   pod_owner: ""

transforms:
  transform_namespace:
    type: remap
    inputs:
      - source_kubernetes
    source: |
      .event_data = .
      .meta_data = %

sinks:
  console:
    type: console
    inputs:
      - transform_namespace
    encoding:
      codec: json

@iFurySt iFurySt requested a review from a team as a code owner August 11, 2024 15:19
@github-actions github-actions bot added domain: sources Anything related to the Vector's sources domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Aug 11, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @iFurySt !

@jszwedko jszwedko enabled auto-merge August 12, 2024 16:58
Signed-off-by: ifuryst <[email protected]>
auto-merge was automatically disabled August 13, 2024 02:49

Head branch was pushed to by a user without write access

@jszwedko jszwedko enabled auto-merge August 13, 2024 14:00
@Anton0C
Copy link

Anton0C commented Jan 13, 2025

What is the status of this issue?

@pront
Copy link
Member

pront commented Jan 13, 2025

What is the status of this issue?

This couldn't be merged due to CI failures. I am going to merge the latest master here to re-trigger the CI checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to suppress pod metadata with log_namespace: true
4 participants