-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Reinstall rustup in MacOS bootstrap #20911
Conversation
The package was renamed from rustup-init to rustup which seems to be causing some issues in CI. Signed-off-by: Jesse Szwedko <[email protected]>
/ci-run-unit-mac |
Signed-off-by: Jesse Szwedko <[email protected]>
/ci-run-unit-mac |
Signed-off-by: Jesse Szwedko <[email protected]>
.github/workflows/unit_mac.yml
Outdated
@@ -48,6 +49,8 @@ | |||
${{ runner.os }}-cargo- | |||
|
|||
- run: bash scripts/environment/bootstrap-macos-10.sh | |||
- name: Setup tmate session |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
Signed-off-by: Jesse Szwedko <[email protected]>
@@ -12,6 +12,12 @@ | |||
|
|||
brew install ruby@3 coreutils cue-lang/tap/cue protobuf | |||
|
|||
# rustup-init (renamed to rustup) is preinstalled on CI, but seems to be lacking the rustup binary |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time |
Regression Detector ResultsRun ID: fd08c314-74a1-4e71-ad47-84996d1a2c29 Metrics dashboard Baseline: 67a5e46 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
❌ | file_to_blackhole | egress throughput | -7.81 | [-14.47, -1.16] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | syslog_humio_logs | ingress throughput | +2.93 | [+2.80, +3.06] | |
➖ | splunk_hec_route_s3 | ingress throughput | +2.13 | [+1.83, +2.44] | |
➖ | http_text_to_http_json | ingress throughput | +1.95 | [+1.83, +2.07] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +1.07 | [+0.92, +1.22] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | +0.79 | [+0.68, +0.90] | |
➖ | syslog_loki | ingress throughput | +0.72 | [+0.64, +0.80] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.48 | [+0.28, +0.69] | |
➖ | otlp_http_to_blackhole | ingress throughput | +0.30 | [+0.13, +0.47] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.01 | [-0.12, +0.13] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.00 | [-0.08, +0.08] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.01 | [-0.11, +0.10] | |
➖ | http_to_http_json | ingress throughput | -0.06 | [-0.16, +0.03] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -0.10 | [-0.23, +0.03] | |
➖ | http_to_http_noack | ingress throughput | -0.12 | [-0.23, -0.00] | |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.37 | [-0.48, -0.26] | |
➖ | fluent_elasticsearch | ingress throughput | -0.45 | [-0.96, +0.06] | |
➖ | socket_to_socket_blackhole | ingress throughput | -0.58 | [-0.64, -0.52] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | -0.61 | [-0.74, -0.48] | |
➖ | http_to_http_acks | ingress throughput | -0.71 | [-2.02, +0.61] | |
➖ | http_to_s3 | ingress throughput | -0.75 | [-1.02, -0.49] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -0.90 | [-0.99, -0.81] | |
➖ | http_elasticsearch | ingress throughput | -1.08 | [-1.24, -0.92] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -1.30 | [-1.43, -1.17] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -2.01 | [-2.23, -1.78] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -2.16 | [-2.34, -1.98] | |
❌ | file_to_blackhole | egress throughput | -7.81 | [-14.47, -1.16] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
* chore(ci): Install rustup in MacOS bootstrap The package was renamed from rustup-init to rustup which seems to be causing some issues in CI. Signed-off-by: Jesse Szwedko <[email protected]> * Ensure rustup in PATH Signed-off-by: Jesse Szwedko <[email protected]> * debug Signed-off-by: Jesse Szwedko <[email protected]> * Reinstall rustup Signed-off-by: Jesse Szwedko <[email protected]> * Actually reinstall Signed-off-by: Jesse Szwedko <[email protected]> * Remove pr trigger Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
* chore(ci): Install rustup in MacOS bootstrap The package was renamed from rustup-init to rustup which seems to be causing some issues in CI. Signed-off-by: Jesse Szwedko <[email protected]> * Ensure rustup in PATH Signed-off-by: Jesse Szwedko <[email protected]> * debug Signed-off-by: Jesse Szwedko <[email protected]> * Reinstall rustup Signed-off-by: Jesse Szwedko <[email protected]> * Actually reinstall Signed-off-by: Jesse Szwedko <[email protected]> * Remove pr trigger Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
The package was renamed from rustup-init to rustup which seems to be causing some issues in CI where the package is already installed (because
rustup-init
was renamed to it) butrustup
doesn't have the actualrustup
binaries downloaded. Reinstalling seems to fix this.