-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add banner alerting people of package migration #19714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized we could/should have done this before. I removed some of the banner code that allows dimsissing it because it caused rendering issues I couldn't resolve easily. Signed-off-by: Jesse Szwedko <[email protected]>
Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build. Heres your preview link: |
jszwedko
added
the
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
label
Jan 25, 2024
Signed-off-by: Jesse Szwedko <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 2094 Passed, 0 Skipped, 1m 24.76s Wall Time |
brett0000FF
approved these changes
Jan 25, 2024
jszwedko
added a commit
that referenced
this pull request
Jan 26, 2024
* chore(docs): Add banner alerting people of package migration I realized we could/should have done this before. I removed some of the banner code that allows dimsissing it because it caused rendering issues I couldn't resolve easily. Signed-off-by: Jesse Szwedko <[email protected]> * spelling Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko
added a commit
that referenced
this pull request
Jan 26, 2024
* chore(docs): Add banner alerting people of package migration I realized we could/should have done this before. I removed some of the banner code that allows dimsissing it because it caused rendering issues I couldn't resolve easily. Signed-off-by: Jesse Szwedko <[email protected]> * spelling Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
AndrooTheChen
pushed a commit
to discord/vector
that referenced
this pull request
Sep 23, 2024
…otdev#19714) * chore(docs): Add banner alerting people of package migration I realized we could/should have done this before. I removed some of the banner code that allows dimsissing it because it caused rendering issues I couldn't resolve easily. Signed-off-by: Jesse Szwedko <[email protected]> * spelling Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-changelog
Changes in this PR do not need user-facing explanations in the release changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized we could/should have done this before. I removed some of the banner code that allows
dimsissing it because it caused rendering issues I couldn't resolve easily.
Signed-off-by: Jesse Szwedko [email protected]