Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vdev): Drop dependency on cached crate #19693

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Jan 23, 2024

The uses of this crate are pretty trivial and not worth pulling an extra dependency.

Replaces #19689

@bruceg bruceg added type: tech debt A code change that does not add user value. dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jan 23, 2024
@bruceg bruceg requested review from jszwedko and a team January 23, 2024 17:26
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Jan 23, 2024
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 23, 2024

Datadog Report

Branch report: bruceg/drop-cached
Commit report: 616a41a
Test service: vector

✅ 0 Failed, 2094 Passed, 0 Skipped, 1m 25.85s Wall Time

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always like dropping dependencies 🎉

@bruceg bruceg enabled auto-merge January 23, 2024 17:49
@bruceg bruceg added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 23, 2024
@bruceg bruceg enabled auto-merge January 24, 2024 14:46
@bruceg bruceg added this pull request to the merge queue Jan 24, 2024
Copy link

Regression Detector Results

Run ID: cc9cbb23-fee0-4118-9bd7-495ef8f27e44
Baseline: 88c10a9
Comparison: 650d478
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_regex_logs2metric_ddmetrics ingress throughput +1.26 [+1.14, +1.39]
syslog_humio_logs ingress throughput +1.23 [+1.13, +1.32]
http_text_to_http_json ingress throughput +1.06 [+0.95, +1.18]
splunk_hec_route_s3 ingress throughput +0.84 [+0.36, +1.32]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.69 [+0.61, +0.78]
syslog_loki ingress throughput +0.59 [+0.53, +0.66]
syslog_splunk_hec_logs ingress throughput +0.53 [+0.48, +0.57]
datadog_agent_remap_blackhole ingress throughput +0.32 [+0.23, +0.41]
otlp_http_to_blackhole ingress throughput +0.28 [+0.13, +0.43]
fluent_elasticsearch ingress throughput +0.22 [-0.24, +0.69]
http_to_http_noack ingress throughput +0.18 [+0.08, +0.27]
http_to_s3 ingress throughput +0.03 [-0.25, +0.31]
http_to_http_json ingress throughput +0.02 [-0.05, +0.10]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.15, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.14, +0.09]
file_to_blackhole egress throughput -0.08 [-2.60, +2.43]
enterprise_http_to_http ingress throughput -0.08 [-0.14, -0.03]
datadog_agent_remap_blackhole_acks ingress throughput -0.14 [-0.25, -0.03]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.26 [-0.35, -0.16]
otlp_grpc_to_blackhole ingress throughput -0.26 [-0.35, -0.18]
socket_to_socket_blackhole ingress throughput -0.41 [-0.49, -0.34]
datadog_agent_remap_datadog_logs ingress throughput -0.62 [-0.72, -0.52]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.96 [-1.08, -0.83]
http_elasticsearch ingress throughput -0.99 [-1.07, -0.92]
http_to_http_acks ingress throughput -1.68 [-2.99, -0.37]
syslog_log2metric_humio_metrics ingress throughput -2.95 [-3.07, -2.83]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 650d478 Jan 24, 2024
42 checks passed
@bruceg bruceg deleted the bruceg/drop-cached branch January 24, 2024 16:53
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants