Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config api): emit graphql field of api config #19692

Merged

Conversation

sebastiantia
Copy link
Contributor

Following up on #19645, this PR emits the new graphql field on app startup and reload

@sebastiantia sebastiantia requested review from dsmith3197 and a team January 23, 2024 17:08
@github-actions github-actions bot added the domain: topology Anything related to Vector's topology code label Jan 23, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: sebtia/OPA-953_add_graphql_field_to_api_internal_event
Commit report: 5a2aac1
Test service: vector

✅ 0 Failed, 2094 Passed, 0 Skipped, 1m 25s Wall Time

Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this can be flagged as no-changelog as the previous graphql PR would have had the actual changelog entry relating to this change.

@sebastiantia sebastiantia added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 23, 2024
@sebastiantia sebastiantia added this pull request to the merge queue Jan 23, 2024
Copy link

Regression Detector Results

Run ID: 2e6cc4b8-8052-448e-8258-b1f475a92dda
Baseline: 53f97c1
Comparison: d4e641c
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_datadog_logs ingress throughput -7.32 [-7.84, -6.81]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
socket_to_socket_blackhole ingress throughput +2.72 [+2.66, +2.78]
otlp_http_to_blackhole ingress throughput +1.94 [+1.80, +2.08]
splunk_hec_route_s3 ingress throughput +1.75 [+1.25, +2.25]
syslog_log2metric_humio_metrics ingress throughput +1.39 [+1.30, +1.48]
syslog_humio_logs ingress throughput +1.10 [+1.00, +1.19]
syslog_loki ingress throughput +0.44 [+0.37, +0.52]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.40 [+0.26, +0.53]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.35 [+0.20, +0.49]
fluent_elasticsearch ingress throughput +0.29 [-0.18, +0.75]
http_to_http_acks ingress throughput +0.24 [-1.07, +1.55]
http_to_http_noack ingress throughput +0.14 [+0.05, +0.23]
http_to_http_json ingress throughput +0.04 [-0.04, +0.11]
http_to_s3 ingress throughput +0.02 [-0.26, +0.31]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.16]
enterprise_http_to_http ingress throughput -0.04 [-0.12, +0.03]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.05 [-0.17, +0.06]
datadog_agent_remap_blackhole_acks ingress throughput -0.10 [-0.21, +0.01]
datadog_agent_remap_blackhole ingress throughput -0.10 [-0.20, -0.00]
file_to_blackhole egress throughput -0.14 [-2.57, +2.29]
otlp_grpc_to_blackhole ingress throughput -0.27 [-0.36, -0.18]
syslog_splunk_hec_logs ingress throughput -0.38 [-0.45, -0.32]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.89 [-0.97, -0.82]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.06 [-1.20, -0.92]
http_text_to_http_json ingress throughput -1.16 [-1.30, -1.03]
http_elasticsearch ingress throughput -1.34 [-1.42, -1.26]
datadog_agent_remap_datadog_logs ingress throughput -7.32 [-7.84, -6.81]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@sebastiantia sebastiantia added this pull request to the merge queue Jan 23, 2024
Copy link

Regression Detector Results

Run ID: 5ed85d3e-909c-41c1-aae2-79f46786663e
Baseline: 1c4813a
Comparison: 3f9e9f7
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +2.04 [+1.91, +2.18]
socket_to_socket_blackhole ingress throughput +1.79 [+1.71, +1.88]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.51 [+1.36, +1.65]
syslog_log2metric_humio_metrics ingress throughput +1.36 [+1.24, +1.48]
file_to_blackhole egress throughput +1.33 [-1.12, +3.78]
splunk_hec_route_s3 ingress throughput +1.33 [+0.82, +1.83]
http_to_http_acks ingress throughput +1.23 [-0.10, +2.56]
http_to_http_noack ingress throughput +1.23 [+1.10, +1.35]
http_text_to_http_json ingress throughput +1.09 [+0.96, +1.23]
otlp_grpc_to_blackhole ingress throughput +0.77 [+0.68, +0.86]
syslog_splunk_hec_logs ingress throughput +0.57 [+0.51, +0.63]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.48 [+0.35, +0.60]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.43 [+0.30, +0.55]
syslog_humio_logs ingress throughput +0.30 [+0.20, +0.41]
fluent_elasticsearch ingress throughput +0.09 [-0.37, +0.56]
http_to_s3 ingress throughput +0.01 [-0.27, +0.30]
http_to_http_json ingress throughput +0.01 [-0.06, +0.08]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14]
syslog_loki ingress throughput -0.02 [-0.08, +0.04]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.07 [-0.18, +0.05]
enterprise_http_to_http ingress throughput -0.09 [-0.15, -0.03]
datadog_agent_remap_datadog_logs ingress throughput -0.24 [-0.32, -0.16]
datadog_agent_remap_blackhole_acks ingress throughput -0.28 [-0.37, -0.18]
datadog_agent_remap_blackhole ingress throughput -0.66 [-0.75, -0.56]
http_elasticsearch ingress throughput -0.69 [-0.76, -0.61]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.76 [-0.84, -0.69]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

Regression Detector Results

Run ID: e2650026-49f9-498d-bda0-2fd4131d5943
Baseline: 0fe1bac
Comparison: f708067
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
socket_to_socket_blackhole ingress throughput +3.51 [+3.43, +3.60]
otlp_http_to_blackhole ingress throughput +3.40 [+3.26, +3.55]
syslog_regex_logs2metric_ddmetrics ingress throughput +2.56 [+2.45, +2.68]
syslog_log2metric_splunk_hec_metrics ingress throughput +2.04 [+1.91, +2.17]
syslog_humio_logs ingress throughput +1.08 [+0.97, +1.19]
http_to_http_acks ingress throughput +0.95 [-0.38, +2.27]
syslog_splunk_hec_logs ingress throughput +0.92 [+0.89, +0.96]
otlp_grpc_to_blackhole ingress throughput +0.74 [+0.65, +0.83]
syslog_loki ingress throughput +0.34 [+0.29, +0.39]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.21 [+0.13, +0.28]
http_to_s3 ingress throughput +0.18 [-0.11, +0.47]
http_to_http_noack ingress throughput +0.07 [-0.03, +0.17]
http_to_http_json ingress throughput +0.05 [-0.03, +0.13]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.15, +0.16]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.08]
enterprise_http_to_http ingress throughput -0.13 [-0.22, -0.05]
datadog_agent_remap_datadog_logs ingress throughput -0.21 [-0.29, -0.12]
file_to_blackhole egress throughput -0.62 [-3.12, +1.88]
fluent_elasticsearch ingress throughput -0.68 [-1.15, -0.22]
http_text_to_http_json ingress throughput -0.87 [-1.01, -0.73]
datadog_agent_remap_blackhole_acks ingress throughput -0.89 [-1.00, -0.78]
http_elasticsearch ingress throughput -0.98 [-1.05, -0.91]
syslog_log2metric_humio_metrics ingress throughput -1.26 [-1.39, -1.13]
datadog_agent_remap_blackhole ingress throughput -1.26 [-1.35, -1.17]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.51 [-1.65, -1.38]
splunk_hec_route_s3 ingress throughput -2.28 [-2.77, -1.79]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

Regression Detector Results

Run ID: 0f35d0bb-0a98-43c2-8363-1c89de51f49c
Baseline: 5d7ceaa
Comparison: 7cf2f00
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_humio_metrics ingress throughput +2.77 [+2.60, +2.94]
socket_to_socket_blackhole ingress throughput +2.24 [+2.18, +2.30]
otlp_http_to_blackhole ingress throughput +1.72 [+1.56, +1.87]
syslog_humio_logs ingress throughput +1.04 [+0.92, +1.16]
file_to_blackhole egress throughput +0.98 [-1.49, +3.45]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.75 [+0.67, +0.83]
splunk_hec_route_s3 ingress throughput +0.60 [+0.09, +1.10]
datadog_agent_remap_datadog_logs ingress throughput +0.37 [+0.27, +0.46]
http_to_http_noack ingress throughput +0.17 [+0.07, +0.27]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.15 [+0.01, +0.29]
http_to_http_json ingress throughput +0.05 [-0.03, +0.13]
syslog_loki ingress throughput +0.03 [-0.03, +0.10]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.15]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.07 [-0.19, +0.04]
enterprise_http_to_http ingress throughput -0.08 [-0.15, -0.00]
http_to_s3 ingress throughput -0.08 [-0.37, +0.21]
fluent_elasticsearch ingress throughput -0.36 [-0.82, +0.10]
http_text_to_http_json ingress throughput -0.38 [-0.51, -0.25]
syslog_splunk_hec_logs ingress throughput -0.41 [-0.47, -0.35]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.45 [-0.56, -0.34]
otlp_grpc_to_blackhole ingress throughput -0.89 [-0.98, -0.81]
http_elasticsearch ingress throughput -0.94 [-1.01, -0.87]
datadog_agent_remap_blackhole_acks ingress throughput -1.20 [-1.30, -1.09]
http_to_http_acks ingress throughput -1.25 [-2.55, +0.04]
datadog_agent_remap_blackhole ingress throughput -2.10 [-2.20, -1.99]
syslog_regex_logs2metric_ddmetrics ingress throughput -3.69 [-3.81, -3.56]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 7cf2f00 Jan 24, 2024
45 of 46 checks passed
@sebastiantia sebastiantia deleted the sebtia/OPA-953_add_graphql_field_to_api_internal_event branch January 24, 2024 03:59
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: topology Anything related to Vector's topology code no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants