chore(ci): fix changelog workflow extern contribs #19524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
domain: ci
jszwedko
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Thinking about this more, I think I'd rather check if the PR is from a fork since this could also cause the workflow to pass on all PRs if the secret was accidentally deleted for some reason. It seems preferable to fail in that situation since it'd be hard to notice.
neuronull
added
the
no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 2075 Passed, 0 Skipped, 1m 24.45s Wall Time |
jszwedko
approved these changes
Jan 5, 2024
AndrooTheChen
pushed a commit
to discord/vector
that referenced
this pull request
Sep 23, 2024
* chore(ci): fix changelog workflow extern contribs * use fork check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow is currently failing external contributor PRs, who don't have the secrets needed in the job step.