Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix link to RFC 3339 #19509

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Jan 3, 2024

The link has had a backslash as separator, effectively disabling the link itself, but actually like in the other examples, a forward slash was necessary.

Status quo on the Website:

image

Will be fixed after being merged.

@bebehei bebehei requested review from a team as code owners January 3, 2024 15:05
@bits-bot
Copy link

bits-bot commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 3, 2024
The link has had a backslash effectively disabling the link itself, but actually like in the other
examples, a forward slash was necessary.
@bebehei bebehei force-pushed the docs-fix-rfc-link branch from 30e6e8c to 444d875 Compare January 3, 2024 15:06
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bebehei !

@jszwedko jszwedko enabled auto-merge January 3, 2024 17:02
@jszwedko jszwedko added this pull request to the merge queue Jan 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2024
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 5, 2024
@jszwedko jszwedko added this pull request to the merge queue Jan 5, 2024
Merged via the queue into vectordotdev:master with commit 3525d06 Jan 5, 2024
39 checks passed
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Fix link to RFC 3339

The link has had a backslash effectively disabling the link itself, but actually like in the other
examples, a forward slash was necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants