Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(greptimedb sink): update ingestion api for greptimedb sink #19410

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Dec 18, 2023

This patch updates greptimedb client to latest version and its row based ingestion API.

@sunng87 sunng87 requested a review from a team December 18, 2023 11:03
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: ci Anything related to Vector's CI environment labels Dec 18, 2023
@sunng87 sunng87 changed the title feat(greptimed sink): update ingestion api for greptimedb sink feat(greptimedb sink): update ingestion api for greptimedb sink Dec 18, 2023
@dsmith3197 dsmith3197 added the sink: greptimedb Anything `greptimedb` sink related label Dec 19, 2023
@StephenWakely StephenWakely added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 5, 2024
@StephenWakely
Copy link
Contributor

@sunng87 A conflict has crept in just before I was going to merge this. Would it be possible to fix this?

@sunng87 sunng87 force-pushed the feature/update-greptimedb-client branch from 7688822 to 4dd54b2 Compare January 9, 2024 11:15
@sunng87
Copy link
Contributor Author

sunng87 commented Jan 10, 2024

Updated @StephenWakely

@StephenWakely
Copy link
Contributor

@sunng87 there still seems to be a conflict, although github isn't saying what file is conflicting.. Can you take a look?

@sunng87 sunng87 force-pushed the feature/update-greptimedb-client branch from 4dd54b2 to 4897a91 Compare January 10, 2024 10:59
@sunng87
Copy link
Contributor Author

sunng87 commented Jan 10, 2024

It seems to be Cargo.lock again. I have pushed a new rebase. Let's check if it works now.

@StephenWakely StephenWakely added this pull request to the merge queue Jan 10, 2024
Copy link

Regression Detector Results

Run ID: 83593904-56b8-498d-a633-4dae10e7da1e
Baseline: 8f504b3
Comparison: 586fb31
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole_acks ingress throughput +1.96 [+1.84, +2.07]
syslog_humio_logs ingress throughput +1.65 [+1.54, +1.77]
syslog_splunk_hec_logs ingress throughput +1.51 [+1.45, +1.57]
datadog_agent_remap_blackhole ingress throughput +1.09 [+1.00, +1.18]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.95 [+0.85, +1.06]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.88 [+0.77, +0.98]
syslog_loki ingress throughput +0.87 [+0.80, +0.95]
fluent_elasticsearch ingress throughput +0.54 [+0.07, +1.01]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.43 [+0.27, +0.60]
http_to_http_acks ingress throughput +0.42 [-0.89, +1.74]
http_to_http_noack ingress throughput +0.18 [+0.08, +0.27]
http_to_http_json ingress throughput +0.04 [-0.04, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.10]
enterprise_http_to_http ingress throughput -0.03 [-0.14, +0.07]
http_to_s3 ingress throughput -0.07 [-0.36, +0.21]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.25 [-0.33, -0.17]
otlp_grpc_to_blackhole ingress throughput -0.38 [-0.47, -0.29]
splunk_hec_route_s3 ingress throughput -0.38 [-0.88, +0.11]
syslog_log2metric_humio_metrics ingress throughput -0.55 [-0.66, -0.45]
file_to_blackhole egress throughput -0.60 [-3.07, +1.88]
http_elasticsearch ingress throughput -1.15 [-1.21, -1.08]
otlp_http_to_blackhole ingress throughput -1.23 [-1.37, -1.10]
datadog_agent_remap_datadog_logs ingress throughput -1.54 [-1.65, -1.44]
http_text_to_http_json ingress throughput -1.64 [-1.77, -1.51]
socket_to_socket_blackhole ingress throughput -3.64 [-3.70, -3.57]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 586fb31 Jan 10, 2024
40 checks passed
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
…ordotdev#19410)

* feat: update ingestion api for greptimedb sink

* fix: lint issues

* chore: update greptime client

* chore: update license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog sink: greptimedb Anything `greptimedb` sink related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants