Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove Cloudsmith package publishing #19378

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jszwedko
Copy link
Member

As part of migration of package hosting: https://vector.dev/highlights/2023-11-07-new-linux-repos/

Signed-off-by: Jesse Szwedko [email protected]

@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Dec 13, 2023
@jszwedko jszwedko enabled auto-merge December 13, 2023 15:12
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/remove-cloudsmith-publish
Commit report: 72b6e44

vector: 0 Failed, 0 New Flaky, 2036 Passed, 0 Skipped, 1m 23.11s Wall Time

@jszwedko jszwedko added this pull request to the merge queue Dec 13, 2023
Copy link

Regression Detector Results

Run ID: a7fb2c93-06f4-485c-a8fb-988bdbf65fa2
Baseline: dff8ca3
Comparison: 290a635
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ denotes better comparison variant performance
  • ❌ denotes worse comparison variant performance

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
splunk_hec_route_s3 ingress throughput +1.53 [+1.01, +2.04] 100.00%
file_to_blackhole egress throughput +0.61 [-1.84, +3.06] 31.97%
http_to_http_acks ingress throughput +0.34 [-0.97, +1.65] 33.02%
fluent_elasticsearch ingress throughput +0.29 [-0.18, +0.76] 69.16%

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
splunk_hec_route_s3 ingress throughput +1.53 [+1.01, +2.04] 100.00%
otlp_http_to_blackhole ingress throughput +1.06 [+0.91, +1.20] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +0.73 [+0.65, +0.80] 100.00%
file_to_blackhole egress throughput +0.61 [-1.84, +3.06] 31.97%
datadog_agent_remap_blackhole_acks ingress throughput +0.59 [+0.48, +0.70] 100.00%
http_to_http_acks ingress throughput +0.34 [-0.97, +1.65] 33.02%
fluent_elasticsearch ingress throughput +0.29 [-0.18, +0.76] 69.16%
http_elasticsearch ingress throughput +0.14 [+0.08, +0.21] 99.98%
http_to_http_noack ingress throughput +0.09 [-0.00, +0.19] 89.23%
syslog_loki ingress throughput +0.00 [-0.05, +0.05] 9.62%
http_to_http_json ingress throughput +0.00 [-0.07, +0.07] 5.65%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14] 1.84%
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14] 0.45%
syslog_regex_logs2metric_ddmetrics ingress throughput -0.01 [-0.14, +0.12] 8.77%
http_to_s3 ingress throughput -0.04 [-0.31, +0.24] 18.48%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.16, +0.07] 45.78%
enterprise_http_to_http ingress throughput -0.12 [-0.18, -0.05] 99.73%
syslog_humio_logs ingress throughput -0.13 [-0.24, -0.03] 96.65%
syslog_log2metric_splunk_hec_metrics ingress throughput -0.22 [-0.35, -0.09] 99.50%
datadog_agent_remap_datadog_logs ingress throughput -0.25 [-0.34, -0.16] 100.00%
otlp_grpc_to_blackhole ingress throughput -0.35 [-0.45, -0.25] 100.00%
syslog_splunk_hec_logs ingress throughput -0.37 [-0.42, -0.32] 100.00%
http_text_to_http_json ingress throughput -0.76 [-0.91, -0.62] 100.00%
socket_to_socket_blackhole ingress throughput -1.12 [-1.20, -1.04] 100.00%
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.32 [-1.43, -1.21] 100.00%
datadog_agent_remap_blackhole ingress throughput -1.71 [-1.83, -1.59] 100.00%
syslog_log2metric_humio_metrics ingress throughput -2.88 [-3.00, -2.75] 100.00%

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 290a635 Dec 13, 2023
43 checks passed
@jszwedko jszwedko deleted the jszwedko/remove-cloudsmith-publish branch December 13, 2023 18:33
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vdev Anything related to the vdev tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants