fix(datadog_logs sink): serialize before batching for more accurate request sizing

[lukesteensen]

Ref #10020

[lukesteensen]

/ci-run-regression

[datadog-vectordotdev]

Datadog Report

Branch report: dd-logs-encoded-before-batch
Commit report: ececd53

✅ vector: 0 Failed, 0 New Flaky, 2197 Passed, 0 Skipped, 21m 43.28s Wall Time

[github-actions]

Regression Detector Results

Run ID: 76ae789c-8b92-434c-9b34-5699b5c4029f
Baseline: f5ea285
Comparison: 35c4cd3
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment	goal	Δ mean %	confidence
datadog_agent_remap_datadog_logs	ingress throughput	-20.64	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-28.77	100.00%

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
socket_to_socket_blackhole	ingress throughput	+2.16	[+2.08, +2.23]	100.00%
otlp_grpc_to_blackhole	ingress throughput	+0.75	[+0.65, +0.85]	100.00%
otlp_http_to_blackhole	ingress throughput	+0.56	[+0.41, +0.72]	100.00%
file_to_blackhole	egress throughput	+0.45	[-1.93, +2.82]	24.35%
syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.16	[+0.03, +0.29]	95.50%
syslog_splunk_hec_logs	ingress throughput	+0.11	[+0.05, +0.16]	99.83%
http_to_http_noack	ingress throughput	+0.09	[+0.01, +0.18]	92.37%
http_to_http_json	ingress throughput	+0.04	[-0.04, +0.11]	60.46%
enterprise_http_to_http	ingress throughput	+0.01	[-0.03, +0.05]	24.94%
splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.14, +0.14]	0.68%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.15, +0.14]	3.46%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.04	[-0.15, +0.08]	39.06%
http_to_s3	ingress throughput	-0.05	[-0.32, +0.23]	21.50%
fluent_elasticsearch	ingress throughput	-0.09	[-0.52, +0.35]	25.17%
http_to_http_acks	ingress throughput	-0.12	[-1.43, +1.19]	11.92%
http_text_to_http_json	ingress throughput	-0.31	[-0.43, -0.18]	100.00%
syslog_humio_logs	ingress throughput	-0.54	[-0.63, -0.46]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	-0.68	[-0.77, -0.60]	100.00%
datadog_agent_remap_blackhole	ingress throughput	-0.72	[-0.81, -0.63]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-1.29	[-1.36, -1.22]	100.00%
syslog_loki	ingress throughput	-1.52	[-1.56, -1.48]	100.00%
splunk_hec_route_s3	ingress throughput	-1.57	[-2.08, -1.07]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	-2.74	[-2.88, -2.61]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	-20.64	[-20.73, -20.56]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-28.77	[-28.86, -28.67]	100.00%

[lukesteensen]

/ci-run-regression

[github-actions]

Regression Detector Results

Run ID: eb9094a5-1a84-4f17-a73f-6e406f6a29d0
Baseline: f5ea285
Comparison: 131822f
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment	goal	Δ mean %	confidence
datadog_agent_remap_datadog_logs	ingress throughput	-20.19	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-27.17	100.00%

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
otlp_http_to_blackhole	ingress throughput	+3.14	[+2.98, +3.29]	100.00%
socket_to_socket_blackhole	ingress throughput	+1.75	[+1.68, +1.83]	100.00%
file_to_blackhole	egress throughput	+1.69	[-0.71, +4.09]	75.39%
syslog_regex_logs2metric_ddmetrics	ingress throughput	+1.00	[+0.92, +1.08]	100.00%
datadog_agent_remap_blackhole	ingress throughput	+0.55	[+0.47, +0.64]	100.00%
datadog_agent_remap_blackhole_acks	ingress throughput	+0.45	[+0.36, +0.54]	100.00%
http_text_to_http_json	ingress throughput	+0.18	[+0.06, +0.30]	98.50%
http_to_http_noack	ingress throughput	+0.12	[+0.04, +0.20]	98.12%
http_to_s3	ingress throughput	+0.05	[-0.22, +0.32]	24.26%
http_to_http_json	ingress throughput	+0.02	[-0.05, +0.09]	28.20%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.00	[-0.14, +0.15]	3.15%
splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.13, +0.14]	3.21%
syslog_humio_logs	ingress throughput	-0.00	[-0.09, +0.08]	1.47%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.05	[-0.17, +0.06]	53.77%
enterprise_http_to_http	ingress throughput	-0.07	[-0.15, -0.00]	90.33%
otlp_grpc_to_blackhole	ingress throughput	-0.13	[-0.23, -0.04]	97.45%
http_to_http_acks	ingress throughput	-0.15	[-1.46, +1.15]	15.52%
syslog_loki	ingress throughput	-0.34	[-0.38, -0.29]	100.00%
syslog_splunk_hec_logs	ingress throughput	-0.54	[-0.59, -0.50]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	-0.55	[-0.69, -0.42]	100.00%
splunk_hec_route_s3	ingress throughput	-0.80	[-1.31, -0.30]	99.09%
syslog_log2metric_humio_metrics	ingress throughput	-1.00	[-1.10, -0.90]	100.00%
fluent_elasticsearch	ingress throughput	-1.15	[-1.59, -0.71]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	-20.19	[-20.27, -20.10]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-27.17	[-27.27, -27.07]	100.00%

[lukesteensen]

/ci-run-regression

[github-actions]

Regression Detector Results

Run ID: 35a28aa0-745b-4e8e-aed6-bc36d70d523a
Baseline: f5ea285
Comparison: dd9a035
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment	goal	Δ mean %	confidence
datadog_agent_remap_datadog_logs	ingress throughput	-22.24	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-28.50	100.00%

Fine details of change detection per experiment.

experiment	goal	Δ mean %	Δ mean % CI	confidence
otlp_grpc_to_blackhole	ingress throughput	+0.90	[+0.80, +0.99]	100.00%
syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.83	[+0.69, +0.97]	100.00%
syslog_log2metric_humio_metrics	ingress throughput	+0.55	[+0.41, +0.69]	100.00%
file_to_blackhole	egress throughput	+0.30	[-2.15, +2.75]	16.00%
datadog_agent_remap_blackhole	ingress throughput	+0.26	[+0.18, +0.34]	100.00%
http_to_http_noack	ingress throughput	+0.14	[+0.05, +0.24]	98.52%
syslog_splunk_hec_logs	ingress throughput	+0.13	[+0.08, +0.18]	100.00%
http_to_http_acks	ingress throughput	+0.06	[-1.25, +1.37]	5.74%
http_to_s3	ingress throughput	+0.05	[-0.23, +0.33]	24.58%
http_to_http_json	ingress throughput	+0.04	[-0.03, +0.11]	61.91%
splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.14, +0.14]	1.65%
splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.15, +0.14]	1.29%
splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.02	[-0.13, +0.10]	19.33%
enterprise_http_to_http	ingress throughput	-0.08	[-0.15, -0.01]	95.25%
datadog_agent_remap_blackhole_acks	ingress throughput	-0.11	[-0.20, -0.03]	96.72%
socket_to_socket_blackhole	ingress throughput	-0.26	[-0.33, -0.19]	100.00%
fluent_elasticsearch	ingress throughput	-0.34	[-0.78, +0.10]	79.90%
http_text_to_http_json	ingress throughput	-0.38	[-0.50, -0.26]	100.00%
syslog_regex_logs2metric_ddmetrics	ingress throughput	-0.46	[-0.58, -0.35]	100.00%
syslog_humio_logs	ingress throughput	-0.47	[-0.54, -0.39]	100.00%
splunk_hec_route_s3	ingress throughput	-0.52	[-1.03, -0.00]	90.13%
syslog_loki	ingress throughput	-1.23	[-1.28, -1.18]	100.00%
otlp_http_to_blackhole	ingress throughput	-1.38	[-1.52, -1.24]	100.00%
datadog_agent_remap_datadog_logs	ingress throughput	-22.24	[-22.32, -22.16]	100.00%
datadog_agent_remap_datadog_logs_acks	ingress throughput	-28.50	[-28.59, -28.41]	100.00%