chore(datadog_agent source, datadog_metrics sink): Add end to end tests with the Datadog Agent for metrics. #18840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tually validating anything
…nto neuronull/sink_datadog_metrics_v2_series_endpoint_conversion
…nto neuronull/sink_datadog_metrics_v2_series_endpoint_conversion
…ndpoint_conversion
This reverts commit c95a326.
…ndpoint_conversion
…ndpoint_conversion
neuronull
commented
Jan 17, 2024
| 19, 11, 6, 17, 5, 0, 1, 17, 17 | ||
| ] | ||
|
|
||
| for i in range(50): |
There was a problem hiding this comment.
The framework in this PR is the bulk of the changes ... if anyone has suggestions on additional test cases to cover, that would be helpful. In theory the framework should hold up and we would just need to extend this code.
bruceg
approved these changes
Jan 24, 2024
dsmith3197
reviewed
Jan 26, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dsmith3197
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds end-to-end tests with the Datadog Agent for the
datadog_agentsource anddatadog_metricssink.This is an extension of #18538
The validation of metrics is more complex than logs.
The validation done is dependent on metric type. In all cases, we can't rely on the timestamps being the same.
Of note: in vector we currently still send to the
v1endpoint. Once we convert to thev2endpoint, some logic here can be removed which is converting the v1 JSON response into the protobuf response. Additionally the JSON response structs were required to be made visible to the e2e module.closes: #18535
epic: #18533