Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): rework Semantic check workflow #14723

Merged
merged 9 commits into from
Oct 22, 2024
Merged

chore(ci): rework Semantic check workflow #14723

merged 9 commits into from
Oct 22, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Oct 4, 2022

Signed-off-by: Jesse Szwedko [email protected]

@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 4ebb8b6
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/633c9f8a9f3efe000872f922

@jszwedko jszwedko force-pushed the try-adding-semantic branch from 43bdde2 to ac230f5 Compare October 4, 2022 20:56
@jszwedko jszwedko marked this pull request as ready for review October 4, 2022 20:58
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko marked this pull request as draft October 4, 2022 21:21
@jszwedko jszwedko changed the title chore: Try adding semantic check chore(ci): Try adding semantic check Jan 26, 2024
Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 26, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: try-adding-semantic
Commit report: 5175982
Test service: vector

✅ 0 Failed, 2094 Passed, 0 Skipped, 1m 24.12s Wall Time

@pront pront marked this pull request as ready for review October 21, 2024 18:43
@pront pront requested a review from a team as a code owner October 21, 2024 18:43
@pront pront changed the title chore(ci): Try adding semantic check chore(ci): add semantic check workflow Oct 21, 2024
@pront pront changed the title chore(ci): add semantic check workflow chore(bad): test Oct 21, 2024
@pront
Copy link
Member

pront commented Oct 21, 2024

@pront pront changed the title chore(bad): test chore(ci): rework Semantic check workflow Oct 21, 2024
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge the latest origin/master and did a couple of checks.

@pront pront enabled auto-merge October 21, 2024 18:46
@pront pront added this pull request to the merge queue Oct 21, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: try-adding-semantic
Commit report: a7f57da
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.47s Total Time

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@pront pront added this pull request to the merge queue Oct 22, 2024
@pront
Copy link
Member

pront commented Oct 22, 2024

hm this should not trigger the regrewssion detector: https://github.com/vectordotdev/vector/actions/runs/11448260287/job/31854883219

@pront pront removed this pull request from the merge queue due to a manual request Oct 22, 2024
@pront pront merged commit 5d8736f into master Oct 22, 2024
69 of 70 checks passed
@pront pront deleted the try-adding-semantic branch October 22, 2024 15:20
@pront
Copy link
Member

pront commented Oct 22, 2024

All checks passed minus the regression detector. I merged this to avoid wasting resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants