Skip to content

Re-enable LTO for x86_64-unknown-linux-musl build #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Oct 16, 2019 · 1 comment
Closed

Re-enable LTO for x86_64-unknown-linux-musl build #1036

ghost opened this issue Oct 16, 2019 · 1 comment
Labels
domain: releasing Anything related to releasing Vector type: task Generic non-code related tasks

Comments

@ghost
Copy link

ghost commented Oct 16, 2019

#794 disabled cross-language LTO because lld was not fully supported. When #1035 is resolved, it would be possible to revert #794 and support LTO again.
@ghost ghost added domain: operations type: task Generic non-code related tasks labels Oct 16, 2019
@ghost ghost mentioned this issue Oct 16, 2019
Closed
@binarylogic binarylogic added meta: blocked Anything that is blocked to the point where it cannot be worked on. and removed needs: fix for another issue labels Nov 27, 2019
@ghost ghost removed the meta: blocked Anything that is blocked to the point where it cannot be worked on. label Nov 30, 2019
@ghost
Copy link
Author

ghost commented Feb 15, 2020 •
edited by ghost
Loading

One of the reasons we haven't re-enabled it earlier is that it slows down builds of tests in CI which are built using scripts/ci-docker-images/builder-*-unknown-linux-musl* Dockerfiles.

However, as we migrate the invocation of CI scripts to tests/Makefile + docker-compose.yml (see #1663), it should be possible to build the builder images with different options for different jobs by specifying args option in docker-compose.yml. Thus the same Dockerfile can be used for building Vector for both tests (with cross-language LTO disabled) and for release archives (with cross-language LTO enabled).

@ghost ghost mentioned this issue Feb 15, 2020
Closed
4 tasks
@binarylogic binarylogic added domain: releasing Anything related to releasing Vector and removed domain: operations labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: releasing Anything related to releasing Vector type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binarylogic