chore: github workflows trigger branches #1688
Conversation
WalkthroughThe pull request introduces modifications to GitHub Actions workflow configurations across three files: Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/on-pr.yml (1)
6-9: LGTM! Consider updating documentation.The branch pattern changes are consistent with other workflow files. Consider updating the repository's contributing guidelines or documentation to reflect these new branch naming patterns that are now supported in the CI/CD pipeline.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/gitleaks.yml(1 hunks).github/workflows/on-main.yml(1 hunks).github/workflows/on-pr.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/gitleaks.yml
[warning] 5-5: wrong indentation: expected 10 but found 8
(indentation)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: rpc-proxy / test / test
- GitHub Check: rpc-proxy / docker / docker
- GitHub Check: unit-integration-test / Build & Lint (latest)
- GitHub Check: unit-integration-test-browser / Build & Lint (latest)
- GitHub Check: unit-integration-test / Build & Lint (lts/*)
- GitHub Check: unit-integration-test-browser / Build & Lint (lts/*)
- GitHub Check: unit-integration-test / Build & Lint (18)
- GitHub Check: unit-integration-test-browser / Build & Lint (18)
- GitHub Check: install-build / Build & Lint
- GitHub Check: test-apps / Install and test example apps
- GitHub Check: Execute doc examples
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
.github/workflows/on-main.yml (1)
8-9: Verify resource usage implications.Running the main CI workflow (which includes build and all test suites) on feature branches could significantly increase CI minutes usage and potentially impact costs.
Let's analyze the current branch patterns and their activity:
✅ Verification successful
No immediate resource impact detected
The new branch patterns ('supported-' and 'feature-') are not currently in use, suggesting this is a proactive change. While there are no immediate resource implications, consider monitoring CI usage once these patterns become active.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check the frequency and volume of matching branches to assess CI resource impact # List all branches matching the new patterns echo "Branches matching new patterns:" git branch -r | grep -E 'supported-|feature-' # Count commits in the last month for matching branches echo -e "\nCommit frequency in the last month:" for pattern in "supported-" "feature-"; do echo "Pattern: $pattern" git log --since="1 month ago" --format="%H" --all | while read commit; do git branch -r --contains $commit | grep $pattern done | sort | uniq -c | sort -nr doneLength of output: 708
Script:
#!/bin/bash # List remote branches matching the patterns echo "Current branches matching patterns:" git branch -r | grep -E 'origin/(supported|feature)-' # Check recent git history for these patterns echo -e "\nRecent commits on matching branches (last 30 days):" git log --all --since="30 days ago" --format="%h %ad %s" --date=short | grep -E '(supported|feature)-'Length of output: 255
.github/workflows/gitleaks.yml (1)
5-8: LGTM! Security checks on all branch types.Expanding gitleaks checks to all branch types is a good security practice to catch potential secret leaks early.
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 5-5: wrong indentation: expected 10 but found 8
(indentation)
| @@ -2,7 +2,10 @@ name: Check for leaks in secrets | |||
| on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
| - 'main' | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix indentation for branch patterns.
The yamllint tool indicates incorrect indentation. Branch patterns should be indented with 10 spaces under branches:.
Apply this diff to fix the indentation:
pull_request:
branches:
- - 'main'
+ - 'main'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - 'main' | |
| - 'main' |
🧰 Tools
🪛 yamllint (1.35.1)
[warning] 5-5: wrong indentation: expected 10 but found 8
(indentation)
Test CoverageSummary
|
Description
Update github workflow trigger branches to beyond just main branch
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Summary by CodeRabbit
main-*,supported-*, andfeature-*branches