Skip to content

Commit

Permalink
Merge pull request #238 from vechainfoundation/237-not-working-with-l…
Browse files Browse the repository at this point in the history
…ast-version-of-yarn

Fix compatibility with node 20
  • Loading branch information
fabiorigam authored Nov 14, 2023
2 parents d6470ca + e521d88 commit 721fabb
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 354 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
node-version: lts/*

- name: Install & Patch packages
run: yarn install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/on-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
node-version: lts/*
- name: Build SDK
run: |
rm -rf ./**/node_modules/
yarn install
yarn build
- name: Test docs
- name: Test docs examples
run: |
cd docs
yarn test:docs
yarn test:examples
install-build:
uses: ./.github/workflows/build-lint.yml
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typedoc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
node-version: lts/*

- name: Install packages
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
node-version: lts/*

- name: Install & Patch packages
run: yarn install
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ packages/**/node_modules
apps/**/dist
apps/**/.turbo
apps/**/node_modules
docs/**/dist

yarn-error.log
# Code coverage folders and files
Expand Down
1 change: 0 additions & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ Note: links that are to be expanded must have text \[example]

* To execute the scripts within `/examples` as tests: `yarn test:examples`
* To build the documentation by expanding examples: `yarn build`
* To execute code from the built documentation (build check): `yarn test:docs`



Expand Down
6 changes: 1 addition & 5 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,15 @@
"type": "module",
"version": "1.0.0",
"scripts": {
"test:docs": "npx runme run --all --category example --skip-prompts",
"test:examples": "ts-node-test examples/",
"build": "find . -name \"*.md\" -type f -maxdepth 1 ! -name \"README.md\" -delete && yarn ts-node builddocs.ts"
"build": "find . -name \"*.md\" -type f -maxdepth 1 ! -name \"README.md\" -delete && tsup builddocs.ts && node dist/builddocs.cjs"
},
"dependencies": {
"@vechain-sdk/core": "*",
"typescript": "^5.2.2"
},
"devDependencies": {
"expect": "^29.7.0",
"runme": "^3.0.2",
"thor-devkit": "^2.0.9",
"ts-node": "^10.9.1",
"ts-node-test": "^0.4.3"
}
}
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"test:unit": "turbo test:unit",
"test:integration": "turbo test:integration",
"format": "turbo format",
"test:docs": "turbo test:docs",
"test:examples": "turbo test:examples",
"merge-coverage": "ts-node scripts/merge-coverage.ts",
"generate:apidocs": "typedoc --options typedoc.json --logLevel Verbose"
Expand Down
3 changes: 0 additions & 3 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
"dependsOn": ["^build"]
},
"format": {},
"test:docs": {
"dependsOn": ["^build"]
},
"test:examples": {
"dependsOn": ["^build"]
}
Expand Down
Loading

1 comment on commit 721fabb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 100%
100% (1122/1122) 100% (317/317) 100% (203/203)
Title Tests Skipped Failures Errors Time
core 303 0 💤 0 ❌ 0 🔥 1m 13s ⏱️
network 62 0 💤 0 ❌ 0 🔥 41.564s ⏱️
errors 19 0 💤 0 ❌ 0 🔥 7.664s ⏱️

Please sign in to comment.