Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test for DeriveRoot function in trie #691

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Adds test for DeriveRoot function in trie #691

merged 2 commits into from
Apr 22, 2024

Conversation

ahasikos
Copy link
Contributor

@ahasikos ahasikos commented Apr 3, 2024

Description

Adds a test for DeriveRoot function of the trie package

Type of change

Adds a test for DeriveRoot using a self generated KAT(Known Answer Test). Given that our implementation differs only in the hash function from Ethereum we assume its correctness.

How Has This Been Tested?

make test

Test Configuration:

  • Go Version: 1.21.8
  • Hardware: darwin/amd64
  • Docker Version: -

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@ahasikos ahasikos requested a review from a team as a code owner April 3, 2024 14:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.32%. Comparing base (c9c4a51) to head (0cc1bef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   57.27%   57.32%   +0.05%     
==========================================
  Files         156      156              
  Lines       17218    17218              
==========================================
+ Hits         9862     9871       +9     
+ Misses       6392     6383       -9     
  Partials      964      964              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony added the next release candidate Ok to merge for next release label Apr 4, 2024
@otherview otherview merged commit bbec4a2 into vechain:master Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release candidate Ok to merge for next release testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants