feat: pass master key as an option #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #690 +/- ##
=======================================
Coverage 57.27% 57.27%
=======================================
Files 156 156
Lines 17218 17218
=======================================
Hits 9862 9862
Misses 6392 6392
Partials 964 964 ☔ View full report in Codecov by Sentry. |
|
@darrenvechain looks good, you may want to document it in the docs? |
Yepp, done here: cea3ec6 |
otherview
previously approved these changes
Apr 3, 2024
| @@ -395,6 +395,20 @@ func masterKeyPath(ctx *cli.Context) (string, error) { | |||
| } | |||
|
|
|||
| func loadNodeMaster(ctx *cli.Context) (*node.Master, error) { | |||
|
|
|||
| masterKey := ctx.String(masterKeyFlag.Name) | |||
| if masterKey != "" { | |||
There was a problem hiding this comment.
Looks good! A small nit to avoid code repetition sugestion would be a small refactor. I think perhaps something like:
- key is set by flag
- otherwise key is set by path
3 if key is set then test beneficiary and return masterkey
There was a problem hiding this comment.
@otherview I made a commit to refactor this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows injection of a master key as a startup flag
Fixes # (issue)
Type of change
How Has This Been Tested?
./bin/thor --network main --master-key eb5cce9a3ba17cd90fd4238cb382d1c47f1c2084f71384f6de6da03a1582d5e6Checklist: