-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for 'finalized' revision in accounts #689
feat: add support for 'finalized' revision in accounts #689
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 61.37% 61.64% +0.26%
==========================================
Files 194 195 +1
Lines 18223 18246 +23
==========================================
+ Hits 11184 11247 +63
+ Misses 5958 5904 -54
- Partials 1081 1095 +14 ☔ View full report in Codecov by Sentry. |
Add finalized to:
Add documentation clarifying what finalized means:
|
Had a discussion with @darrenvechain, transaction's endpoint does not need |
Do not forget to sync the version |
Co-authored-by: libotony <[email protected]>
Co-authored-by: libotony <[email protected]>
Description
This PR allows clients to specify
finalized
as a revision on the accounts endpoints.The solo instance is also modified to return the best block as the finalized block
Type of change
How Has This Been Tested?
accounts_test.go
Checklist: