Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed assertion roullete test smell. #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed assertion roullete test smell. #157

wants to merge 1 commit into from

Conversation

leofernandesmo
Copy link

@leofernandesmo leofernandesmo commented Jul 16, 2020 •
edited
Loading

The idea is to have just one assert per test method.
Besides, I also changed the signature of some methods to make them more expressive.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 92.625% when pulling 4979aba on leofernandesmo:remove-assertion-roullet into 9a90624 on vdurmont:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leofernandesmo @coveralls