Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify accessRight #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

modify accessRight #2

wants to merge 1 commit into from

Conversation

lsaejn
Copy link

@lsaejn lsaejn commented Apr 26, 2021

No description provided.

@vczh
Copy link
Member

vczh commented May 8, 2021

FileStream::AccessRight::ReadWrite mean to open an empty file. It is easy to verify by running the unit test, your change will cause a failure.

If you need "r+b", please add a new item with unit test.

vczh
vczh requested changes May 8, 2021
View reviewed changes
Copy link
Member

@vczh vczh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"w+b" is desired, see "Conversation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vczh vczh vczh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsaejn @vczh