Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from FactoryGirl to FactoryBot #13

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

isabel22
Copy link

@isabel22 isabel22 commented Oct 3, 2018

As the gem has been updated and changed its name from FactoryGirl to FactoryBot, I decided to make the the change as suggested in the documentation of thoughtbot.

After updating, I ran rspec and noticed that there was an error:

DEPRECATION WARNING: Static attributes will be removed in FactoryBot 5.0. Please use dynamic attributes instead by wrapping the attribute value in a block.

To fix this warning and automatically update from static attributes to dynamic attributes, I installed locally rubocop-rspec and ran:

rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct

This warning was fixed in the second commit.

This PR contributes to #10.

@isabel22 isabel22 changed the title Updating from FactoryGirl to FactoryBot Update from FactoryGirl to FactoryBot Oct 3, 2018
@isabel22 isabel22 changed the base branch from master to develop October 3, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant