Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

49 passing cluster labels broken #63

Merged
merged 6 commits into from
Oct 18, 2024
Merged

49 passing cluster labels broken #63

merged 6 commits into from
Oct 18, 2024

Conversation

vc1492a
Copy link
Owner

@vc1492a vc1492a commented Oct 11, 2024

@IroNEDR can you please review the changes in this PR that address the issue described in #49?

@vc1492a vc1492a added bug Something isn't working review This issue is under review and will (hopefully) be closed soon labels Oct 11, 2024
@vc1492a vc1492a added this to the Address Existing Bug Fixes milestone Oct 11, 2024
@vc1492a vc1492a requested a review from IroNEDR October 11, 2024 23:29
@vc1492a vc1492a linked an issue Oct 11, 2024 that may be closed by this pull request
Passing cluster_labels broken #49
Closed
@vc1492a
Copy link
Owner Author

vc1492a commented Oct 11, 2024

Screenshot 2024-10-11 at 4 40 13 PM

Noting that I have the distributions ready for PyPI should everything check out during the review process. Process will be as follows:

  1. Review approval and merge to dev.
  2. Delete 49-passing-cluster_labels-broken branch.
  3. Confirm no additional changes are needed. Push package to PyPI.
  4. Merge dev with main (will require review).
  5. Wait for release-please PR that updates changes to README.md and will subsequently create a tagged release (this process is new to us, this will be the first live test).

@vc1492a vc1492a linked an issue Oct 11, 2024 that may be closed by this pull request
Add library download and usage statistics #44
Closed
@vc1492a vc1492a mentioned this pull request Oct 11, 2024
Closed
IroNEDR
IroNEDR approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@IroNEDR IroNEDR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it carefully. Looks really good.

@vc1492a vc1492a merged commit bbdd12a into dev Oct 18, 2024
9 checks passed
@vc1492a vc1492a deleted the 49-passing-cluster_labels-broken branch October 18, 2024 12:31
@vc1492a vc1492a mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IroNEDR IroNEDR IroNEDR approved these changes

Assignees

@vc1492a vc1492a

@IroNEDR IroNEDR

Labels
bug Something isn't working review This issue is under review and will (hopefully) be closed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing cluster_labels broken Add library download and usage statistics
2 participants
@vc1492a @IroNEDR