Move continuous integration from Travis CI to Github Actions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just runs flake8 and pytest to verify our builds. See issue: #51
added another push trigger just to test the workflow within the feature branch
…e have a working flake8 configuration
merge dev into feature branch
don't stop build due to flake8 errors. should be changed later once we have a working flake8 configuration
installation of requirements_ci.txt as part of the workflow
…e for newer ubuntu versions
…in numpy version used by Python3.6
IroNEDR
changed the title
IroNEDR
changed the title
Closed
|
@IroNEDR I have approved the PR, looks good to me. I will hold off on merging and deleting the feature branch for now, but next time if you would like me to proceed with the merge and with deleting the feature branch please let me know 🔧 |
|
@vc1492a no worries, good thing you didn't merge yet. I renamed the workflow file and added a test status badge to the readme to replace the old travis badge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our free travis CI credit ran out a long time ago. With this PR we move the our current CI Pipeline from travis to github actions.
With this new pipeline we test for Python versions 3.6 - 3.12. During the process some regressions in our unit tests on older Python versions were discovered such as using the
tupleinstead ofTuplein the type annotations. These small fixes are included in this PR.An interesting read regarding costs etc.:
https://docs.github.com/en/actions/administering-github-actions/usage-limits-billing-and-administration
According to this, we fall under the free category.