Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new scaling from Yamauchi and Takei 2024 #86

Merged
merged 20 commits into from
Apr 19, 2024

Conversation

chrishavlin
Copy link
Member

@chrishavlin chrishavlin commented Apr 5, 2024

This adds the new Yamauchi and Takei 2024 scaling for super-solidus melt effects.

The initial implementation of the pre-melt scaling actually included placeholders for some constants, so it was very easy to use the existing function by adding a new flag. To use the new scaling, you add the same xfit_premelt to the methods list and then set the new include_direct_melt_effect flag to 1:

  VBR.in.anelastic.methods_list={'xfit_premelt'};
  VBR.in.anelastic.xfit_premelt.include_direct_melt_effect = 1;

For now the default is include_direct_melt_effect=0, but eventually it may make sense to have the default set to 1.

This initial push does run but I haven't validated anything.

Still to do:

  • add tests
  • update docs
  • validate (the paper includes a zenodo link to data)

Closes #85

@chrishavlin chrishavlin added the enhancement New feature or request label Apr 5, 2024
@chrishavlin chrishavlin marked this pull request as draft April 5, 2024 20:28
@chrishavlin chrishavlin added this to the v1.2.0 milestone Apr 5, 2024
@chrishavlin chrishavlin marked this pull request as ready for review April 19, 2024 21:10
@chrishavlin chrishavlin merged commit 8454db0 into vbr-calc:main Apr 19, 2024
2 checks passed
@chrishavlin chrishavlin deleted the yamauchi_takei_2024_scaling branch April 19, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: implement new Yamauchi and Takei scaling
1 participant