-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new scaling from Yamauchi and Takei 2024 #86
Merged
chrishavlin
merged 20 commits into
vbr-calc:main
from
chrishavlin:yamauchi_takei_2024_scaling
Apr 19, 2024
Merged
Adding new scaling from Yamauchi and Takei 2024 #86
chrishavlin
merged 20 commits into
vbr-calc:main
from
chrishavlin:yamauchi_takei_2024_scaling
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishavlin
commented
Apr 5, 2024
chrishavlin
commented
Apr 5, 2024
chrishavlin
commented
Apr 5, 2024
chrishavlin
commented
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new Yamauchi and Takei 2024 scaling for super-solidus melt effects.
The initial implementation of the pre-melt scaling actually included placeholders for some constants, so it was very easy to use the existing function by adding a new flag. To use the new scaling, you add the same
xfit_premelt
to the methods list and then set the newinclude_direct_melt_effect
flag to 1:For now the default is
include_direct_melt_effect=0
, but eventually it may make sense to have the default set to 1.This initial push does run but I haven't validated anything.
Still to do:
Closes #85