Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank TextField and LongTextField #1356

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Blank TextField and LongTextField #1356

merged 2 commits into from
Jul 25, 2024

Conversation

piotrpospiech
Copy link
Collaborator

Closes #1332

  • Deleting input from TextField and LongTextField sets undefined instead of empty string in the model
  • This behavior is already implemented in other fields (playground with optional TextField and NumField)

@piotrpospiech piotrpospiech added this to the v4.0 milestone Jun 24, 2024
@github-actions github-actions bot added Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package labels Jun 24, 2024
@github-actions github-actions bot added the Area: Core Affects the uniforms package label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (e1c4707) to head (09e150d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   95.02%   95.03%   +0.01%     
==========================================
  Files         175      175              
  Lines        2892     2900       +8     
  Branches      763      777      +14     
==========================================
+ Hits         2748     2756       +8     
  Misses         59       59              
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotrpospiech piotrpospiech merged commit 6fe2b41 into master Jul 25, 2024
7 checks passed
@piotrpospiech piotrpospiech deleted the text-field-optional branch July 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Blank field gives error even though optional
4 participants