Add playground to sparrowql #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monteth
approved these changes
Oct 13, 2023
playground/src/examples/example2.ts
Outdated
Comment on lines
1
to
19
| export const example2 = `const aliases = { | ||
| 'owners': 'users', | ||
| 'employees': 'users' | ||
| } | ||
|
|
||
| const relations = [ | ||
| { from: 'employments', local: 'salonId', to: 'salons', foreign: '_id'}, | ||
| { from: 'salons', local: 'businessId', to: 'businesses', foreign: '_id'}, | ||
| { from: 'businesses', local: 'ownerId', to: 'owners', foreign: '_id'}, | ||
| { from: 'employments', local: 'userId', to: 'employees', foreign: '_id'}, | ||
| ]; | ||
|
|
||
| const start = 'employments'; | ||
|
|
||
| const projection = { | ||
| salonName: 'salons.name', | ||
| employee: 'employees.firstName', | ||
| employer: 'owners.firstName' | ||
| };`; |
There was a problem hiding this comment.
Suggested change
| export const example2 = `const aliases = { | |
| 'owners': 'users', | |
| 'employees': 'users' | |
| } | |
| const relations = [ | |
| { from: 'employments', local: 'salonId', to: 'salons', foreign: '_id'}, | |
| { from: 'salons', local: 'businessId', to: 'businesses', foreign: '_id'}, | |
| { from: 'businesses', local: 'ownerId', to: 'owners', foreign: '_id'}, | |
| { from: 'employments', local: 'userId', to: 'employees', foreign: '_id'}, | |
| ]; | |
| const start = 'employments'; | |
| const projection = { | |
| salonName: 'salons.name', | |
| employee: 'employees.firstName', | |
| employer: 'owners.firstName' | |
| };`; | |
| export const example2 = `const aliases = { | |
| 'owners': 'users', | |
| 'employees': 'users' | |
| } | |
| const relations = [ | |
| { from: 'employments', local: 'restaurantId', to: 'restaurants', foreign: '_id'}, | |
| { from: 'restaurants', local: 'businessId', to: 'businesses', foreign: '_id'}, | |
| { from: 'businesses', local: 'ownerId', to: 'owners', foreign: '_id'}, | |
| { from: 'employments', local: 'userId', to: 'employees', foreign: '_id'}, | |
| ]; | |
| const start = 'employments'; | |
| const projection = { | |
| restaurantName: 'restaurants.name', | |
| employee: 'employees.name', | |
| employer: 'owners.name' | |
| };`; |
Comment on lines
+6
to
+15
| const fn = ` | ||
| function get() { | ||
| if (typeof aliases !== 'undefined') { | ||
| return {projection, relations, start, aliases }; | ||
| } | ||
| return { projection, relations, start }; | ||
| } | ||
|
|
||
| get(); | ||
| `; |
There was a problem hiding this comment.
TODO: Add other parameters like limit, offset, and so on.
| updateQuery(example1); | ||
| } | ||
| }, []); | ||
| const _setInput = (value: string) => { |
There was a problem hiding this comment.
To distinguish it from the state change, maybe let's change the name to something like onInputChanged, or change the state update to setPlaygroundInputState
| const hash = '?' + encoded; | ||
| window.location.hash = hash; | ||
| } catch (_) { | ||
| // It's alright. |
There was a problem hiding this comment.
Can we put a console error or warning?
kestarumper
reviewed
Oct 23, 2023
.github/workflows/CI.yml
Outdated
Comment on lines
30
to
31
| - name: Install dependencies | ||
| run: npm i -g npm@8 --no-audit && npm ci --no-audit | ||
| run: npm i -g npm@8 --no-audit && npm ci --no-audit && cd playground && npm ci --no-audit |
There was a problem hiding this comment.
[optional]
Maybe it's worth splitting it into separate phases?
Monteth
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add playground to sparrowql