Some corrections and code refactoring #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pull request made by @mgufrone
…svg fill properties. Added some supported attributes.
machour
reviewed
Mar 29, 2018
| } | ||
|
|
||
| inspectNode(node){ | ||
| // Remove empty strings from children array | ||
| trimElementChilden = (childrens) => childrens.filter((children) => typeof children !== 'string' || children.trim.length !== 0) |
There was a problem hiding this comment.
this should be trim().
I've started a fork of this library named react-native-svg-from-uri
Do you mind if I use parts of this PR in it?
There was a problem hiding this comment.
I’ll make the correction tomorrow!
|
@matc4 did you take the change to review this? |
|
Hello @rcacheira !, can you resolve the conflicts, and we merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'have included the pull request #75 and #88, with some corrections and code refactoring, thanks to @BerndSchrooten and @mgufrone.
The code is now supporting:
<style><clipPath>viewBoxpropertystylepropertyclasspropertyThi pull request solves the most common problem of SVG showing black.
fixes #86
closes #75
closes #88